fix: add the Authorization header to the cache key to avoid reading cache data without a valid netbox token that was used to read the data from netbox.

Author: thenodon

README.md

@@ -70,8 +70,7 @@ and the parser will be used to parse the data into a format that can be used by
 The web_proxy_cache can be used with http based service discovery in Prometheus. The service discovery can in principle 
 be used for any api call for the netbox api, but the exporter is designed to work with the 
 `/dcim/devices/` endpoint where the filter return a hugh amount of entries.
-To format the output for service discovery use the `X-Forwarded-For` header with the value
-`service_discovery`.
+To format the output for service discovery use the `X-Forwarded-For` header with the value `service-discovery`.
 > The reason for this implementation is that it has been observed that the netbox plugin 
 > [netbox-plugin-prometheus-sd](https://github.com/FlxPeters/netbox-plugin-prometheus-sd) 
 > will take a vary long time to return the result or even return 500 or 504 (probobly proxy timeout) 

provider/netbox/proxy.go

@@ -87,8 +87,7 @@ func Endpoint(w http.ResponseWriter, r *http.Request) {
 func cacheHandling(w http.ResponseWriter, r *http.Request) {
 	r.URL.Path = strings.TrimPrefix(r.URL.Path, fmt.Sprintf("/%s", Netbox))
 
-	key := fmt.Sprintf("%s%s?%s", r.Header.Get("X-Forwarded-Host"), r.URL.Path, r.URL.RawQuery)
-
+	key := getCacheKey(r)
 	var cacheData interface{}
 	var ok bool
 	cacheData, ok = cache[Netbox].Get(key)
@@ -165,11 +164,6 @@ func serviceDiscovery(cacheData interface{}) ([]map[string]interface{}, error) {
 	}
 
 	results := raw.Results
-	/*
-		if !ok {
-			return nil, fmt.Errorf("missing or malformed 'results' field in JSON data")
-		}
-	*/
 
 	var sd []map[string]interface{}
 	for _, entry := range results {
@@ -411,6 +405,11 @@ func getForwardContentData(r *http.Request) (string, int, error) {
 		Data:            result,
 	}
 
-	cache[Netbox].Set(fmt.Sprintf("%s%s?%s", r.Header.Get("X-Forwarded-Host"), r.URL.Path, r.URL.RawQuery), cacheData)
+	cache[Netbox].Set(getCacheKey(r), cacheData)
 	return "Success", http.StatusOK, nil
 }
+
+// getCacheKey generates a unique cache key based on the request URL and relevant headers
+func getCacheKey(r *http.Request) string {
+	return fmt.Sprintf("%s%s?%s-%s", r.Header.Get("X-Forwarded-Host"), r.URL.Path, r.URL.RawQuery, r.Header.Get("Authorization"))
+}