Skip to content

Commit 40546ae

Browse files
shiftkeytheofficialgman
authored andcommitted
get arm CI building again by forking archived packages (shiftkey#1190)
* use forked fs-admin package with prebuilds for armv7l and other platforms * doot * attempt the second * do we see anything different on node-gyp@11 * rename import to point to new package name * bump to newer version * also fix prebuilds for keytar to actually work
1 parent ce8feaf commit 40546ae

5 files changed

Lines changed: 45 additions & 36 deletions

File tree

app/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@
3737
"electron-window-state": "^5.0.3",
3838
"event-kit": "^2.0.0",
3939
"focus-trap-react": "^8.1.0",
40-
"fs-admin": "^0.19.0",
40+
"fs-admin-forked": "^0.23.0",
4141
"fuzzaldrin-plus": "^0.6.0",
42-
"keytar": "^7.8.0",
42+
"keytar-forked": "^7.10.0",
4343
"lodash": "^4.17.21",
4444
"marked": "^4.0.10",
4545
"mem": "^4.3.0",

app/src/lib/stores/token-store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as keytar from 'keytar'
1+
import * as keytar from 'keytar-forked'
22

33
function setItem(key: string, login: string, value: string) {
44
return keytar.setPassword(key, login, value)

app/src/ui/lib/install-cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as Path from 'path'
22

3-
import * as fsAdmin from 'fs-admin'
3+
import * as fsAdmin from 'fs-admin-forked'
44
import { mkdir, readlink, symlink, unlink } from 'fs/promises'
55

66
/** The path for the installed command line tool. */

app/yarn.lock

Lines changed: 38 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -476,13 +476,13 @@ focus-trap@^6.1.0:
476476
dependencies:
477477
tabbable "^5.1.0"
478478

479-
fs-admin@^0.19.0:
480-
version "0.19.0"
481-
resolved "https://registry.yarnpkg.com/fs-admin/-/fs-admin-0.19.0.tgz#c2b077b21607ca1982bf9bc8c3fc096be7a1186e"
482-
integrity sha512-GtJUlSqX95Daw1zlH9PtqMIpr+yQqUnCRKxupuwdlPGy4ds+ICNT3apyQlnT1yXiXvAdnTK06ag/4jMS/jzhXQ==
479+
fs-admin-forked@^0.23.0:
480+
version "0.23.0"
481+
resolved "https://registry.yarnpkg.com/fs-admin-forked/-/fs-admin-forked-0.23.0.tgz#4fcdf64a2d7758a52c67bbc87b1ff7a592ff6803"
482+
integrity sha512-1sFLqKsArQPtzEcMys8vsxDod0hVi5Q2Vsev2h+UZ7vXTQz++mUe01uHkS+r9Yj0zjLT0Dwefv3c5a1dCAW7xg==
483483
dependencies:
484-
node-addon-api "^3.1.0"
485-
prebuild-install "^6.0.0"
484+
node-addon-api "^8.3.0"
485+
prebuild-install "^7.1.3"
486486

487487
fs-constants@^1.0.0:
488488
version "1.0.0"
@@ -624,13 +624,13 @@ jszip@^3.1.0:
624624
readable-stream "~2.3.6"
625625
setimmediate "^1.0.5"
626626

627-
keytar@^7.8.0:
628-
version "7.8.0"
629-
resolved "https://registry.yarnpkg.com/keytar/-/keytar-7.8.0.tgz#28cf5ceeb1275350888870022869b8b4fe6a87f9"
630-
integrity sha512-mR+BqtAOIW8j+T5FtLVyckCbvROWQD+4FzPeFMuk5njEZkXLpVPCGF26Y3mTyxMAAL1XCfswR7S6kIf+THSRFA==
627+
keytar-forked@^7.10.0:
628+
version "7.10.0"
629+
resolved "https://registry.yarnpkg.com/keytar-forked/-/keytar-forked-7.10.0.tgz#dbb78e16b18a40fc61df58124228855a7e8c912d"
630+
integrity sha512-MrH3Id3Bjf4av3zGihBK62NucgBOVbTzchnSRPtA14sWRj9xu7roFa9NddlxC6Nt98EdrQpu04MZXnuusV+b5w==
631631
dependencies:
632-
node-addon-api "^4.3.0"
633-
prebuild-install "^7.0.1"
632+
node-addon-api "^8.3.0"
633+
prebuild-install "^7.1.3"
634634

635635
kuler@^2.0.0:
636636
version "2.0.0"
@@ -764,6 +764,11 @@ napi-build-utils@^1.0.1:
764764
resolved "https://registry.yarnpkg.com/napi-build-utils/-/napi-build-utils-1.0.1.tgz#1381a0f92c39d66bf19852e7873432fc2123e508"
765765
integrity sha512-boQj1WFgQH3v4clhu3mTNfP+vOBxorDlE8EKiMjUlLG3C4qAESnn9AxIOkFgTR2c9LtzNjPrjS60cT27ZKBhaA==
766766

767+
napi-build-utils@^2.0.0:
768+
version "2.0.0"
769+
resolved "https://registry.yarnpkg.com/napi-build-utils/-/napi-build-utils-2.0.0.tgz#13c22c0187fcfccce1461844136372a47ddc027e"
770+
integrity sha512-GEbrYkbfF7MoNaoh2iGG84Mnf/WZfB0GdGEsM8wz7Expx/LlWf5U8t9nvJKXSp3qr5IsEbK04cBGhol/KwOsWA==
771+
767772
nice-try@^1.0.4:
768773
version "1.0.5"
769774
resolved "https://registry.yarnpkg.com/nice-try/-/nice-try-1.0.5.tgz#a3378a7696ce7d223e88fc9b764bd7ef1089e366"
@@ -798,6 +803,11 @@ node-addon-api@^7.0.0:
798803
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-7.1.1.tgz#1aba6693b0f255258a049d621329329322aad558"
799804
integrity sha512-5m3bsyrjFWE1xf7nz7YXdN4udnVtXK6/Yfgn5qnahL6bCkf2yKt4k3nuTKAtT4r3IG8JNR2ncsIMdZuAzJjHQQ==
800805

806+
node-addon-api@^8.3.0:
807+
version "8.3.0"
808+
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-8.3.0.tgz#ec3763f18befc1cdf66d11e157ce44d5eddc0603"
809+
integrity sha512-8VOpLHFrOQlAH+qA0ZzuGRlALRA6/LVh8QJldbrC4DY0hXoMP0l4Acq8TzFC018HztWiRqyCEj2aTWY2UvnJUg==
810+
801811
noop-logger@^0.1.1:
802812
version "0.1.1"
803813
resolved "https://registry.yarnpkg.com/noop-logger/-/noop-logger-0.1.1.tgz#94a2b1633c4f1317553007d8966fd0e841b6a4c2"
@@ -910,31 +920,29 @@ prebuild-install@^5.3.5:
910920
tunnel-agent "^0.6.0"
911921
which-pm-runs "^1.0.0"
912922

913-
prebuild-install@^6.0.0:
914-
version "6.0.0"
915-
resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-6.0.0.tgz#669022bcde57c710a869e39c5ca6bf9cd207f316"
916-
integrity sha512-h2ZJ1PXHKWZpp1caLw0oX9sagVpL2YTk+ZwInQbQ3QqNd4J03O6MpFNmMTJlkfgPENWqe5kP0WjQLqz5OjLfsw==
923+
prebuild-install@^7.0.1:
924+
version "7.0.1"
925+
resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-7.0.1.tgz#c10075727c318efe72412f333e0ef625beaf3870"
926+
integrity sha512-QBSab31WqkyxpnMWQxubYAHR5S9B2+r81ucocew34Fkl98FhvKIF50jIJnNOBmAZfyNV7vE5T6gd3hTVWgY6tg==
917927
dependencies:
918-
detect-libc "^1.0.3"
928+
detect-libc "^2.0.0"
919929
expand-template "^2.0.3"
920930
github-from-package "0.0.0"
921931
minimist "^1.2.3"
922932
mkdirp-classic "^0.5.3"
923933
napi-build-utils "^1.0.1"
924-
node-abi "^2.7.0"
925-
noop-logger "^0.1.1"
934+
node-abi "^3.3.0"
926935
npmlog "^4.0.1"
927936
pump "^3.0.0"
928937
rc "^1.2.7"
929-
simple-get "^3.0.3"
938+
simple-get "^4.0.0"
930939
tar-fs "^2.0.0"
931940
tunnel-agent "^0.6.0"
932-
which-pm-runs "^1.0.0"
933941

934-
prebuild-install@^7.0.1:
935-
version "7.0.1"
936-
resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-7.0.1.tgz#c10075727c318efe72412f333e0ef625beaf3870"
937-
integrity sha512-QBSab31WqkyxpnMWQxubYAHR5S9B2+r81ucocew34Fkl98FhvKIF50jIJnNOBmAZfyNV7vE5T6gd3hTVWgY6tg==
942+
prebuild-install@^7.1.2:
943+
version "7.1.2"
944+
resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-7.1.2.tgz#a5fd9986f5a6251fbc47e1e5c65de71e68c0a056"
945+
integrity sha512-UnNke3IQb6sgarcZIDU3gbMeTp/9SSU1DAIkil7PrqG1vZlBtY5msYccSKSHDqa3hNg436IXK+SNImReuA1wEQ==
938946
dependencies:
939947
detect-libc "^2.0.0"
940948
expand-template "^2.0.3"
@@ -943,24 +951,23 @@ prebuild-install@^7.0.1:
943951
mkdirp-classic "^0.5.3"
944952
napi-build-utils "^1.0.1"
945953
node-abi "^3.3.0"
946-
npmlog "^4.0.1"
947954
pump "^3.0.0"
948955
rc "^1.2.7"
949956
simple-get "^4.0.0"
950957
tar-fs "^2.0.0"
951958
tunnel-agent "^0.6.0"
952959

953-
prebuild-install@^7.1.2:
954-
version "7.1.2"
955-
resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-7.1.2.tgz#a5fd9986f5a6251fbc47e1e5c65de71e68c0a056"
956-
integrity sha512-UnNke3IQb6sgarcZIDU3gbMeTp/9SSU1DAIkil7PrqG1vZlBtY5msYccSKSHDqa3hNg436IXK+SNImReuA1wEQ==
960+
prebuild-install@^7.1.3:
961+
version "7.1.3"
962+
resolved "https://registry.yarnpkg.com/prebuild-install/-/prebuild-install-7.1.3.tgz#d630abad2b147443f20a212917beae68b8092eec"
963+
integrity sha512-8Mf2cbV7x1cXPUILADGI3wuhfqWvtiLA1iclTDbFRZkgRQS0NqsPZphna9V+HyTEadheuPmjaJMsbzKQFOzLug==
957964
dependencies:
958965
detect-libc "^2.0.0"
959966
expand-template "^2.0.3"
960967
github-from-package "0.0.0"
961968
minimist "^1.2.3"
962969
mkdirp-classic "^0.5.3"
963-
napi-build-utils "^1.0.1"
970+
napi-build-utils "^2.0.0"
964971
node-abi "^3.3.0"
965972
pump "^3.0.0"
966973
rc "^1.2.7"

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
"klaw-sync": "^3.0.0",
8383
"legal-eagle": "0.16.0",
8484
"mini-css-extract-plugin": "^2.9.1",
85+
"node-gyp": "^11.0.0",
8586
"parallel-webpack": "^2.6.0",
8687
"parse-dds": "^1.2.1",
8788
"prettier": "^2.6.0",
@@ -170,5 +171,6 @@
170171
"electron-installer-debian": "3.2.0",
171172
"electron-installer-redhat": "3.4.0",
172173
"electron-winstaller": "^5.0.0"
173-
}
174+
},
175+
"packageManager": "yarn@1.22.19+sha1.4ba7fc5c6e704fce2066ecbfb0b0d8976fe62447"
174176
}

0 commit comments

Comments
 (0)