Skip to content

Commit 0db9957

Browse files
Stefan Bindingtiwai
authored andcommitted
ASoC: cs35l41: Move cs_dsp config struct into shared code
This can then be used by HDA code to configure cs_dsp. Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com> Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://lore.kernel.org/r/20220509214703.4482-9-vitalyr@opensource.cirrus.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent ff8aad0 commit 0db9957

3 files changed

Lines changed: 28 additions & 18 deletions

File tree

include/sound/cs35l41.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#define __CS35L41_H
1212

1313
#include <linux/regmap.h>
14+
#include <linux/firmware/cirrus/cs_dsp.h>
1415

1516
#define CS35L41_FIRSTREG 0x00000000
1617
#define CS35L41_LASTREG 0x03804FE8
@@ -877,6 +878,7 @@ int cs35l41_set_channels(struct device *dev, struct regmap *reg,
877878
unsigned int tx_num, unsigned int *tx_slot,
878879
unsigned int rx_num, unsigned int *rx_slot);
879880
int cs35l41_gpio_config(struct regmap *regmap, struct cs35l41_hw_cfg *hw_cfg);
881+
void cs35l41_configure_cs_dsp(struct device *dev, struct regmap *reg, struct cs_dsp *dsp);
880882
int cs35l41_set_cspl_mbox_cmd(struct device *dev, struct regmap *regmap,
881883
enum cs35l41_cspl_mbox_cmd cmd);
882884
int cs35l41_write_fs_errata(struct device *dev, struct regmap *regmap);

sound/soc/codecs/cs35l41-lib.c

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include <linux/regmap.h>
1313
#include <linux/regulator/consumer.h>
1414
#include <linux/slab.h>
15+
#include <linux/firmware/cirrus/wmfw.h>
1516

1617
#include <sound/cs35l41.h>
1718

@@ -1225,6 +1226,29 @@ int cs35l41_gpio_config(struct regmap *regmap, struct cs35l41_hw_cfg *hw_cfg)
12251226
}
12261227
EXPORT_SYMBOL_GPL(cs35l41_gpio_config);
12271228

1229+
static const struct cs_dsp_region cs35l41_dsp1_regions[] = {
1230+
{ .type = WMFW_HALO_PM_PACKED, .base = CS35L41_DSP1_PMEM_0 },
1231+
{ .type = WMFW_HALO_XM_PACKED, .base = CS35L41_DSP1_XMEM_PACK_0 },
1232+
{ .type = WMFW_HALO_YM_PACKED, .base = CS35L41_DSP1_YMEM_PACK_0 },
1233+
{. type = WMFW_ADSP2_XM, .base = CS35L41_DSP1_XMEM_UNPACK24_0},
1234+
{. type = WMFW_ADSP2_YM, .base = CS35L41_DSP1_YMEM_UNPACK24_0},
1235+
};
1236+
1237+
void cs35l41_configure_cs_dsp(struct device *dev, struct regmap *reg, struct cs_dsp *dsp)
1238+
{
1239+
dsp->num = 1;
1240+
dsp->type = WMFW_HALO;
1241+
dsp->rev = 0;
1242+
dsp->dev = dev;
1243+
dsp->regmap = reg;
1244+
dsp->base = CS35L41_DSP1_CTRL_BASE;
1245+
dsp->base_sysinfo = CS35L41_DSP1_SYS_ID;
1246+
dsp->mem = cs35l41_dsp1_regions;
1247+
dsp->num_mems = ARRAY_SIZE(cs35l41_dsp1_regions);
1248+
dsp->lock_regions = 0xFFFFFFFF;
1249+
}
1250+
EXPORT_SYMBOL_GPL(cs35l41_configure_cs_dsp);
1251+
12281252
static bool cs35l41_check_cspl_mbox_sts(enum cs35l41_cspl_mbox_cmd cmd,
12291253
enum cs35l41_cspl_mbox_status sts)
12301254
{

sound/soc/codecs/cs35l41.c

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -680,14 +680,6 @@ static const struct snd_soc_dapm_route cs35l41_audio_map[] = {
680680
{"CLASS H", NULL, "PCM Source"},
681681
};
682682

683-
static const struct cs_dsp_region cs35l41_dsp1_regions[] = {
684-
{ .type = WMFW_HALO_PM_PACKED, .base = CS35L41_DSP1_PMEM_0 },
685-
{ .type = WMFW_HALO_XM_PACKED, .base = CS35L41_DSP1_XMEM_PACK_0 },
686-
{ .type = WMFW_HALO_YM_PACKED, .base = CS35L41_DSP1_YMEM_PACK_0 },
687-
{. type = WMFW_ADSP2_XM, .base = CS35L41_DSP1_XMEM_UNPACK24_0},
688-
{. type = WMFW_ADSP2_YM, .base = CS35L41_DSP1_YMEM_UNPACK24_0},
689-
};
690-
691683
static int cs35l41_set_channel_map(struct snd_soc_dai *dai, unsigned int tx_n,
692684
unsigned int *tx_slot, unsigned int rx_n, unsigned int *rx_slot)
693685
{
@@ -1100,18 +1092,10 @@ static int cs35l41_dsp_init(struct cs35l41_private *cs35l41)
11001092

11011093
dsp = &cs35l41->dsp;
11021094
dsp->part = "cs35l41";
1103-
dsp->cs_dsp.num = 1;
1104-
dsp->cs_dsp.type = WMFW_HALO;
1105-
dsp->cs_dsp.rev = 0;
11061095
dsp->fw = 9; /* 9 is WM_ADSP_FW_SPK_PROT in wm_adsp.c */
11071096
dsp->toggle_preload = true;
1108-
dsp->cs_dsp.dev = cs35l41->dev;
1109-
dsp->cs_dsp.regmap = cs35l41->regmap;
1110-
dsp->cs_dsp.base = CS35L41_DSP1_CTRL_BASE;
1111-
dsp->cs_dsp.base_sysinfo = CS35L41_DSP1_SYS_ID;
1112-
dsp->cs_dsp.mem = cs35l41_dsp1_regions;
1113-
dsp->cs_dsp.num_mems = ARRAY_SIZE(cs35l41_dsp1_regions);
1114-
dsp->cs_dsp.lock_regions = 0xFFFFFFFF;
1097+
1098+
cs35l41_configure_cs_dsp(cs35l41->dev, cs35l41->regmap, &dsp->cs_dsp);
11151099

11161100
ret = cs35l41_write_fs_errata(cs35l41->dev, cs35l41->regmap);
11171101
if (ret < 0)

0 commit comments

Comments
 (0)