ASoC: max98090: Generate notifications on changes for custom control

broonie · broonie · commit 13fcf676d9e1 · 2022-04-25T13:58:16.000+01:00
The max98090 driver has some custom controls which share a put() function which returns 0 unconditionally, meaning that events are not generated when the value changes. Fix that. Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
@@ -430,7 +430,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol,
 		mask << mc->shift,
 		sel << mc->shift);
 
-	return 0;
+	return *select != val;
 }
 
 static const char *max98090_perf_pwr_text[] =

Original file line number	Diff line number	Diff line change
`@@ -430,7 +430,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol,`
`430`	`430`	`mask << mc->shift,`
`431`	`431`	`sel << mc->shift);`
`432`	`432`
`433`		`- return 0;`
	`433`	`+ return *select != val;`
`434`	`434`	`}`
`435`	`435`
`436`	`436`	`static const char *max98090_perf_pwr_text[] =`