Skip to content

Commit 47f6c5d

Browse files
committed
ASoC: rt715-sdca: wait codec init in hw_params
Move regmap sync to rt715_sdca_update_status() when unattach_request is set, and only do regmap sync in resume when no reattach needed. And move waiting codec init to hw_params when the codec really need to be initialized. The change can shorten the resume time. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
1 parent bf9d692 commit 47f6c5d

2 files changed

Lines changed: 31 additions & 12 deletions

File tree

sound/soc/codecs/rt715-sdca-sdw.c

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ static int rt715_sdca_update_status(struct sdw_slave *slave,
120120
enum sdw_slave_status status)
121121
{
122122
struct rt715_sdca_priv *rt715 = dev_get_drvdata(&slave->dev);
123+
int ret;
123124

124125
/*
125126
* Perform initialization only if slave status is present and
@@ -129,7 +130,29 @@ static int rt715_sdca_update_status(struct sdw_slave *slave,
129130
return 0;
130131

131132
/* perform I/O transfers required for Slave initialization */
132-
return rt715_sdca_io_init(&slave->dev, slave);
133+
ret = rt715_sdca_io_init(&slave->dev, slave);
134+
if (ret < 0) {
135+
dev_err(&slave->dev, "IO init failed: %d\n", ret);
136+
return ret;
137+
}
138+
139+
if (slave->unattach_request) {
140+
regcache_cache_only(rt715->regmap, false);
141+
regcache_sync_region(rt715->regmap,
142+
SDW_SDCA_CTL(FUN_JACK_CODEC, RT715_SDCA_ST_EN, RT715_SDCA_ST_CTRL,
143+
CH_00),
144+
SDW_SDCA_CTL(FUN_MIC_ARRAY, RT715_SDCA_SMPU_TRIG_ST_EN,
145+
RT715_SDCA_SMPU_TRIG_ST_CTRL, CH_00));
146+
regcache_cache_only(rt715->mbq_regmap, false);
147+
regcache_sync_region(rt715->mbq_regmap, 0x2000000, 0x61020ff);
148+
regcache_sync_region(rt715->mbq_regmap,
149+
SDW_SDCA_CTL(FUN_JACK_CODEC, RT715_SDCA_ST_EN, RT715_SDCA_ST_CTRL,
150+
CH_00),
151+
SDW_SDCA_CTL(FUN_MIC_ARRAY, RT715_SDCA_SMPU_TRIG_ST_EN,
152+
RT715_SDCA_SMPU_TRIG_ST_CTRL, CH_00));
153+
}
154+
155+
return ret;
133156
}
134157

135158
static int rt715_sdca_read_prop(struct sdw_slave *slave)
@@ -220,28 +243,18 @@ static int rt715_dev_suspend(struct device *dev)
220243
return 0;
221244
}
222245

223-
#define RT715_PROBE_TIMEOUT 5000
224-
225246
static int rt715_dev_resume(struct device *dev)
226247
{
227248
struct sdw_slave *slave = dev_to_sdw_dev(dev);
228249
struct rt715_sdca_priv *rt715 = dev_get_drvdata(dev);
229-
unsigned long time;
230250

231251
if (!rt715->first_hw_init)
232252
return 0;
233253

234254
if (!slave->unattach_request)
235255
goto regmap_sync;
236256

237-
time = wait_for_completion_timeout(&slave->initialization_complete,
238-
msecs_to_jiffies(RT715_PROBE_TIMEOUT));
239-
if (!time) {
240-
dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
241-
sdw_show_ping_status(slave->bus, true);
242-
243-
return -ETIMEDOUT;
244-
}
257+
return 0;
245258

246259
regmap_sync:
247260
slave->unattach_request = 0;

sound/soc/codecs/rt715-sdca.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -792,6 +792,8 @@ static void rt715_sdca_shutdown(struct snd_pcm_substream *substream,
792792
snd_soc_dai_set_dma_data(dai, substream, NULL);
793793
}
794794

795+
#define RT715_PROBE_TIMEOUT 5000
796+
795797
static int rt715_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
796798
struct snd_pcm_hw_params *params,
797799
struct snd_soc_dai *dai)
@@ -830,6 +832,10 @@ static int rt715_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
830832
return -EINVAL;
831833
}
832834

835+
retval = sdw_slave_wait_for_initialization(rt715->slave, RT715_PROBE_TIMEOUT);
836+
if (retval < 0)
837+
return retval;
838+
833839
retval = sdw_stream_add_slave(rt715->slave, &stream_config,
834840
&port_config, 1, sdw_stream);
835841
if (retval) {

0 commit comments

Comments
 (0)