Skip to content

Commit 507cd12

Browse files
committed
ALSA: hda: Disable codec runtime PM when jack polling is enabled
When the jack polling is triggered quite frequently, it makes little sense to perform the runtime PM at each time; since we do almost full configuration at each runtime resume for HD-audio, the merit by power saving would be lost. Hence, it'd be more reasonable to disable the runtime PM when the jack polling is enabled. This patch introduces the runtime PM idle callback and disables the runtime PM when the jack polling is enabled. This also serves as the preliminary change for the further jack poll cleanup. The exception is the case where codec->bus->jackpoll_in_suspend flag is set by the driver (currently set by HD-audio Tegra driver). This flag indicates that the polling is infrequent, hence there is still benefit to perform the runtime PM. The idle callback checks this flag and allows the runtime PM when set. Link: https://lore.kernel.org/20250619020844.2974160-1-joakim.zhang@cixtech.com Tested-by: Joakim Zhang <joakim.zhang@cixtech.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> Link: https://patch.msgid.link/20250623131437.10670-3-tiwai@suse.de
1 parent 1adcbdf commit 507cd12

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

sound/pci/hda/hda_codec.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2943,6 +2943,15 @@ static int hda_codec_runtime_resume(struct device *dev)
29432943
return 0;
29442944
}
29452945

2946+
static int hda_codec_runtime_idle(struct device *dev)
2947+
{
2948+
struct hda_codec *codec = dev_to_hda_codec(dev);
2949+
2950+
if (codec->jackpoll_interval && !codec->bus->jackpoll_in_suspend)
2951+
return -EBUSY;
2952+
return 0;
2953+
}
2954+
29462955
static int hda_codec_pm_prepare(struct device *dev)
29472956
{
29482957
struct hda_codec *codec = dev_to_hda_codec(dev);
@@ -3008,7 +3017,8 @@ const struct dev_pm_ops hda_codec_driver_pm = {
30083017
.thaw = pm_sleep_ptr(hda_codec_pm_thaw),
30093018
.poweroff = pm_sleep_ptr(hda_codec_pm_suspend),
30103019
.restore = pm_sleep_ptr(hda_codec_pm_restore),
3011-
RUNTIME_PM_OPS(hda_codec_runtime_suspend, hda_codec_runtime_resume, NULL)
3020+
RUNTIME_PM_OPS(hda_codec_runtime_suspend, hda_codec_runtime_resume,
3021+
hda_codec_runtime_idle)
30123022
};
30133023

30143024
/* suspend the codec at shutdown; called from driver's shutdown callback */

0 commit comments

Comments
 (0)