Skip to content

Commit 579e7b8

Browse files
wangdichengtiwai
authored andcommitted
ALSA: hda/cmedia: Remove duplicate pin configuration parsing
The cmedia_probe() function calls snd_hda_parse_pin_defcfg() and snd_hda_gen_parse_auto_config() twice unnecessarily. Remove The duplicate code. Fixes: 0f1e830 ("ALSA: hda/cmedia: Rewrite to new probe method") Signed-off-by: wangdicheng <wangdicheng@kylinos.cn> Link: https://patch.msgid.link/20260401082625.157868-1-wangdich9700@163.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 5ed060d commit 579e7b8

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

sound/hda/codecs/cmedia.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,6 @@ static int cmedia_probe(struct hda_codec *codec, const struct hda_device_id *id)
3939
spec->out_vol_mask = (1ULL << 0x10);
4040
}
4141

42-
err = snd_hda_parse_pin_defcfg(codec, cfg, NULL, 0);
43-
if (err < 0)
44-
goto error;
45-
err = snd_hda_gen_parse_auto_config(codec, cfg);
46-
if (err < 0)
47-
goto error;
48-
4942
err = snd_hda_parse_pin_defcfg(codec, cfg, NULL, 0);
5043
if (err < 0)
5144
goto error;

0 commit comments

Comments
 (0)