Skip to content

Commit 6985def

Browse files
charleskeepaxbroonie
authored andcommitted
regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing
Avoid a hole in struct regmap_mbq_context by shuffling the members slightly. Pahole before: struct regmap_mbq_context { struct device * dev; /* 0 8 */ struct sdw_slave * sdw; /* 8 8 */ struct regmap_sdw_mbq_cfg cfg; /* 16 32 */ int val_size; /* 48 4 */ /* XXX 4 bytes hole, try to pack */ bool (*readable_reg)(struct device *, unsigned int); /* 56 8 */ /* size: 64, cachelines: 1, members: 5 */ /* sum members: 60, holes: 1, sum holes: 4 */ }; Pahole after: struct regmap_mbq_context { struct device * dev; /* 0 8 */ struct sdw_slave * sdw; /* 8 8 */ bool (*readable_reg)(struct device *, unsigned int); /* 16 8 */ struct regmap_sdw_mbq_cfg cfg; /* 24 32 */ int val_size; /* 56 4 */ /* size: 64, cachelines: 1, members: 5 */ /* padding: 4 */ }; Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://patch.msgid.link/20251107104551.1553526-1-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent af9c809 commit 6985def

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/base/regmap/regmap-sdw-mbq.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@
1616
struct regmap_mbq_context {
1717
struct device *dev;
1818

19+
bool (*readable_reg)(struct device *dev, unsigned int reg);
20+
1921
struct regmap_sdw_mbq_cfg cfg;
2022

2123
int val_size;
22-
bool (*readable_reg)(struct device *dev, unsigned int reg);
2324
};
2425

2526
static int regmap_sdw_mbq_size(struct regmap_mbq_context *ctx, unsigned int reg)

0 commit comments

Comments
 (0)