Skip to content

Commit 72919c5

Browse files
crazo7924tiwai
authored andcommitted
ALSA: hda/realtek: add HP Victus 16-e0xxx mute LED quirk
HP Victus 16-e0xxx with ALC245 codec does not handle the toggling of the mute LED. This patch adds a quirk entry for subsystem ID 0x88eb using a new ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT fixup, enabling correct mute LED behavior. Signed-off-by: Bharat Dev Burman <bharat.singh7924@gmail.com> Link: https://patch.msgid.link/20260112184253.33376-1-bharat.singh7924@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 0924c6b commit 72919c5

1 file changed

Lines changed: 22 additions & 0 deletions

File tree

sound/hda/codecs/realtek/alc269.c

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1551,6 +1551,22 @@ static void alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
15511551
}
15521552
}
15531553

1554+
static void alc245_fixup_hp_mute_led_v2_coefbit(struct hda_codec *codec,
1555+
const struct hda_fixup *fix,
1556+
int action)
1557+
{
1558+
struct alc_spec *spec = codec->spec;
1559+
1560+
if (action == HDA_FIXUP_ACT_PRE_PROBE) {
1561+
spec->mute_led_polarity = 0;
1562+
spec->mute_led_coef.idx = 0x0b;
1563+
spec->mute_led_coef.mask = 1 << 3;
1564+
spec->mute_led_coef.on = 1 << 3;
1565+
spec->mute_led_coef.off = 0;
1566+
snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
1567+
}
1568+
}
1569+
15541570
/* turn on/off mic-mute LED per capture hook by coef bit */
15551571
static int coef_micmute_led_set(struct led_classdev *led_cdev,
15561572
enum led_brightness brightness)
@@ -3816,6 +3832,7 @@ enum {
38163832
ALC287_FIXUP_YOGA7_14ARB7_I2C,
38173833
ALC245_FIXUP_HP_MUTE_LED_COEFBIT,
38183834
ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT,
3835+
ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT,
38193836
ALC245_FIXUP_HP_X360_MUTE_LEDS,
38203837
ALC287_FIXUP_THINKPAD_I2S_SPK,
38213838
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD,
@@ -6132,6 +6149,10 @@ static const struct hda_fixup alc269_fixups[] = {
61326149
.type = HDA_FIXUP_FUNC,
61336150
.v.func = alc245_fixup_hp_mute_led_v1_coefbit,
61346151
},
6152+
[ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT] = {
6153+
.type = HDA_FIXUP_FUNC,
6154+
.v.func = alc245_fixup_hp_mute_led_v2_coefbit,
6155+
},
61356156
[ALC245_FIXUP_HP_X360_MUTE_LEDS] = {
61366157
.type = HDA_FIXUP_FUNC,
61376158
.v.func = alc245_fixup_hp_mute_led_coefbit,
@@ -6620,6 +6641,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
66206641
SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
66216642
SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),
66226643
SND_PCI_QUIRK(0x103c, 0x88dd, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
6644+
SND_PCI_QUIRK(0x103c, 0x88eb, "HP Victus 16-e0xxx", ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT),
66236645
SND_PCI_QUIRK(0x103c, 0x8902, "HP OMEN 16", ALC285_FIXUP_HP_MUTE_LED),
66246646
SND_PCI_QUIRK(0x103c, 0x890e, "HP 255 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
66256647
SND_PCI_QUIRK(0x103c, 0x8919, "HP Pavilion Aero Laptop 13-be0xxx", ALC287_FIXUP_HP_GPIO_LED),

0 commit comments

Comments
 (0)