ASoC: ti: j721e-evm: Check for not initialized parent_clk_id

ujfalusi · broonie · commit 82d28b67f780 · 2021-07-19T12:58:42.000+01:00
During probe the parent_clk_id is set to -1 which should not be used to array index within hsdiv_rates[]. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> Link: https://lore.kernel.org/r/20210717122820.1467-3-peter.ujfalusi@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c
@@ -197,7 +197,7 @@ static int j721e_configure_refclk(struct j721e_priv *priv,
 		return ret;
 	}
 
-	if (priv->hsdiv_rates[domain->parent_clk_id] != scki) {
+	if (domain->parent_clk_id == -1 || priv->hsdiv_rates[domain->parent_clk_id] != scki) {
 		dev_dbg(priv->dev,
 			"%s configuration for %u Hz: %s, %dxFS (SCKI: %u Hz)\n",
 			audio_domain == J721E_AUDIO_DOMAIN_CPB ? "CPB" : "IVI",

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ static int j721e_configure_refclk(struct j721e_priv *priv,`
`197`	`197`	`return ret;`
`198`	`198`	`}`
`199`	`199`
`200`		`- if (priv->hsdiv_rates[domain->parent_clk_id] != scki) {`
	`200`	`+ if (domain->parent_clk_id == -1 \|\| priv->hsdiv_rates[domain->parent_clk_id] != scki) {`
`201`	`201`	`dev_dbg(priv->dev,`
`202`	`202`	`"%s configuration for %u Hz: %s, %dxFS (SCKI: %u Hz)\n",`
`203`	`203`	`audio_domain == J721E_AUDIO_DOMAIN_CPB ? "CPB" : "IVI",`