Skip to content

Commit 84faa91

Browse files
haruki3hhhbroonie
authored andcommitted
ASoC: fsl: imx-rpmsg: use snd_soc_find_dai_with_mutex() in probe
imx_rpmsg_probe() calls snd_soc_find_dai() without holding client_mutex. However, snd_soc_find_dai() has lockdep_assert_held(&client_mutex) indicating callers must hold this lock, as the function iterates over the global component list. All other callers of snd_soc_find_dai() either hold client_mutex via the snd_soc_bind_card() path or use the snd_soc_find_dai_with_mutex() wrapper. Use snd_soc_find_dai_with_mutex() instead to fix the missing lock protection. Signed-off-by: Ziyi Guo <n7l8m4@u.northwestern.edu> Reviewed-by: Frank Li <Frank.Li@nxp.com> Link: https://patch.msgid.link/20260205052429.4046903-1-n7l8m4@u.northwestern.edu Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent fef1f75 commit 84faa91

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/fsl/imx-rpmsg.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
145145
data->dai.ignore_pmdown_time = 1;
146146

147147
data->dai.cpus->dai_name = pdev->dev.platform_data;
148-
cpu_dai = snd_soc_find_dai(data->dai.cpus);
148+
cpu_dai = snd_soc_find_dai_with_mutex(data->dai.cpus);
149149
if (!cpu_dai) {
150150
ret = -EPROBE_DEFER;
151151
goto fail;

0 commit comments

Comments
 (0)