Skip to content

Commit 8a066a8

Browse files
bellegarde-cbroonie
authored andcommitted
ASoC: qcom: q6asm: drop DSP responses for closed data streams
'Commit a354f03 ("ASoC: qcom: q6asm: handle the responses after closing")' attempted to ignore DSP responses arriving after a stream had been closed. However, those responses were still handled, causing lockups. Fix this by unconditionally dropping all DSP responses associated with closed data streams. Signed-off-by: Cédric Bellegarde <cedric.bellegarde@adishatz.org> Link: https://patch.msgid.link/20260102215225.609166-1-cedric.bellegarde@adishatz.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 090c884 commit 8a066a8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

sound/soc/qcom/qdsp6/q6asm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,6 @@ static int32_t q6asm_stream_callback(struct apr_device *adev,
636636
client_event = ASM_CLIENT_EVENT_CMD_OUT_FLUSH_DONE;
637637
break;
638638
case ASM_STREAM_CMD_OPEN_WRITE_V3:
639-
case ASM_DATA_CMD_WRITE_V2:
640639
case ASM_STREAM_CMD_OPEN_READ_V3:
641640
case ASM_STREAM_CMD_OPEN_READWRITE_V2:
642641
case ASM_STREAM_CMD_SET_ENCDEC_PARAM:
@@ -655,8 +654,9 @@ static int32_t q6asm_stream_callback(struct apr_device *adev,
655654
break;
656655
case ASM_DATA_CMD_EOS:
657656
case ASM_DATA_CMD_READ_V2:
657+
case ASM_DATA_CMD_WRITE_V2:
658658
/* response as result of close stream */
659-
break;
659+
goto done;
660660
default:
661661
dev_err(ac->dev, "command[0x%x] not expecting rsp\n",
662662
result->opcode);

0 commit comments

Comments
 (0)