Skip to content

Commit 910f42b

Browse files
robherringbroonie
authored andcommitted
ASoC: dt-bindings: Fix patternProperties with fixed strings
The simple-audio-card and renesas,rsnd bindings used 'patternProperties' with fixed strings to work-around a dtschema meta-schema limitation. This is now fixed and the schemas can be fixed to use 'properties' instead. Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20220311234802.417610-1-robh@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent ccb4214 commit 910f42b

2 files changed

Lines changed: 28 additions & 30 deletions

File tree

Documentation/devicetree/bindings/sound/renesas,rsnd.yaml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,7 @@ properties:
123123
$ref: audio-graph-port.yaml#
124124
unevaluatedProperties: false
125125

126-
# use patternProperties to avoid naming "xxx,yyy" issue
127-
patternProperties:
128-
"^rcar_sound,dvc$":
126+
rcar_sound,dvc:
129127
description: DVC subnode.
130128
type: object
131129
patternProperties:
@@ -141,7 +139,7 @@ patternProperties:
141139
- dma-names
142140
additionalProperties: false
143141

144-
"^rcar_sound,mix$":
142+
rcar_sound,mix:
145143
description: MIX subnode.
146144
type: object
147145
patternProperties:
@@ -150,7 +148,7 @@ patternProperties:
150148
# no properties
151149
additionalProperties: false
152150

153-
"^rcar_sound,ctu$":
151+
rcar_sound,ctu:
154152
description: CTU subnode.
155153
type: object
156154
patternProperties:
@@ -159,7 +157,7 @@ patternProperties:
159157
# no properties
160158
additionalProperties: false
161159

162-
"^rcar_sound,src$":
160+
rcar_sound,src:
163161
description: SRC subnode.
164162
type: object
165163
patternProperties:
@@ -182,7 +180,7 @@ patternProperties:
182180
- dma-names
183181
additionalProperties: false
184182

185-
"^rcar_sound,ssiu$":
183+
rcar_sound,ssiu:
186184
description: SSIU subnode.
187185
type: object
188186
patternProperties:
@@ -202,7 +200,7 @@ patternProperties:
202200
- dma-names
203201
additionalProperties: false
204202

205-
"^rcar_sound,ssi$":
203+
rcar_sound,ssi:
206204
description: SSI subnode.
207205
type: object
208206
patternProperties:
@@ -239,7 +237,7 @@ patternProperties:
239237
additionalProperties: false
240238

241239
# For DAI base
242-
"^rcar_sound,dai$":
240+
rcar_sound,dai:
243241
description: DAI subnode.
244242
type: object
245243
patternProperties:

Documentation/devicetree/bindings/sound/simple-card.yaml

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -167,45 +167,45 @@ properties:
167167
description: User specified audio sound card name.
168168
$ref: /schemas/types.yaml#/definitions/string
169169

170-
# use patternProperties to avoid naming "xxx,yyy" issue
171-
patternProperties:
172-
"^simple-audio-card,widgets$":
170+
simple-audio-card,widgets:
173171
$ref: "#/definitions/widgets"
174-
"^simple-audio-card,routing$":
172+
simple-audio-card,routing:
175173
$ref: "#/definitions/routing"
176-
"^simple-audio-card,cpu(@[0-9a-f]+)?":
177-
$ref: "#/definitions/dai"
178-
"^simple-audio-card,codec(@[0-9a-f]+)?":
179-
$ref: "#/definitions/dai"
180174

181175
# common properties
182-
"^simple-audio-card,frame-master$":
176+
simple-audio-card,frame-master:
183177
$ref: "#/definitions/frame-master"
184-
"^simple-audio-card,bitclock-master$":
178+
simple-audio-card,bitclock-master:
185179
$ref: "#/definitions/bitclock-master"
186-
"^simple-audio-card,frame-inversion$":
180+
simple-audio-card,frame-inversion:
187181
$ref: "#/definitions/frame-inversion"
188-
"^simple-audio-card,bitclock-inversion$":
182+
simple-audio-card,bitclock-inversion:
189183
$ref: "#/definitions/bitclock-inversion"
190-
"^simple-audio-card,format$":
184+
simple-audio-card,format:
191185
$ref: "#/definitions/format"
192-
"^simple-audio-card,mclk-fs$":
186+
simple-audio-card,mclk-fs:
193187
$ref: "#/definitions/mclk-fs"
194-
"^simple-audio-card,aux-devs$":
188+
simple-audio-card,aux-devs:
195189
$ref: "#/definitions/aux-devs"
196-
"^simple-audio-card,convert-rate$":
190+
simple-audio-card,convert-rate:
197191
$ref: "#/definitions/convert-rate"
198-
"^simple-audio-card,convert-channels$":
192+
simple-audio-card,convert-channels:
199193
$ref: "#/definitions/convert-channels"
200-
"^simple-audio-card,prefix$":
194+
simple-audio-card,prefix:
201195
$ref: "#/definitions/prefix"
202-
"^simple-audio-card,pin-switches$":
196+
simple-audio-card,pin-switches:
203197
$ref: "#/definitions/pin-switches"
204-
"^simple-audio-card,hp-det-gpio$":
198+
simple-audio-card,hp-det-gpio:
205199
maxItems: 1
206-
"^simple-audio-card,mic-det-gpio$":
200+
simple-audio-card,mic-det-gpio:
207201
maxItems: 1
208202

203+
patternProperties:
204+
"^simple-audio-card,cpu(@[0-9a-f]+)?$":
205+
$ref: "#/definitions/dai"
206+
"^simple-audio-card,codec(@[0-9a-f]+)?$":
207+
$ref: "#/definitions/dai"
208+
209209
"^simple-audio-card,dai-link(@[0-9a-f]+)?$":
210210
description: |
211211
Container for dai-link level properties and the CPU and CODEC sub-nodes.

0 commit comments

Comments
 (0)