soundwire: qcom: return error when pm_runtime_get_sync fails

plbossart · plbossart · commit 981440b901fa · 2022-04-25T12:02:57.000-05:00
For some reason there's a missing error return in two places. Fixes: 74e79da ("soundwire: qcom: add runtime pm support") Fixes: 04d46a7 ("soundwire: qcom: add in-band wake up interrupt support") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
@@ -516,6 +516,7 @@ static irqreturn_t qcom_swrm_wake_irq_handler(int irq, void *dev_id)
 				    "pm_runtime_get_sync failed in %s, ret %d\n",
 				    __func__, ret);
 		pm_runtime_put_noidle(swrm->dev);
+		return ret;
 	}
 
 	if (swrm->wake_irq > 0) {
@@ -1258,6 +1259,7 @@ static int swrm_reg_show(struct seq_file *s_file, void *data)
 				    "pm_runtime_get_sync failed in %s, ret %d\n",
 				    __func__, ret);
 		pm_runtime_put_noidle(swrm->dev);
+		return ret;
 	}
 
 	for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {

Original file line number	Diff line number	Diff line change
`@@ -516,6 +516,7 @@ static irqreturn_t qcom_swrm_wake_irq_handler(int irq, void *dev_id)`
`516`	`516`	`"pm_runtime_get_sync failed in %s, ret %d\n",`
`517`	`517`	`__func__, ret);`
`518`	`518`	`pm_runtime_put_noidle(swrm->dev);`
	`519`	`+ return ret;`
`519`	`520`	`}`
`520`	`521`
`521`	`522`	`if (swrm->wake_irq > 0) {`
`@@ -1258,6 +1259,7 @@ static int swrm_reg_show(struct seq_file s_file, void data)`
`1258`	`1259`	`"pm_runtime_get_sync failed in %s, ret %d\n",`
`1259`	`1260`	`__func__, ret);`
`1260`	`1261`	`pm_runtime_put_noidle(swrm->dev);`
	`1262`	`+ return ret;`
`1261`	`1263`	`}`
`1262`	`1264`
`1263`	`1265`	`for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {`