@@ -152,11 +152,8 @@ void devfreq_get_freq_range(struct devfreq *devfreq,
152152 (unsigned long )HZ_PER_KHZ * qos_max_freq );
153153
154154 /* Apply constraints from OPP interface */
155- * min_freq = max (* min_freq , devfreq -> scaling_min_freq );
156- * max_freq = min (* max_freq , devfreq -> scaling_max_freq );
157-
158- if (* min_freq > * max_freq )
159- * min_freq = * max_freq ;
155+ * max_freq = clamp (* max_freq , devfreq -> scaling_min_freq , devfreq -> scaling_max_freq );
156+ * min_freq = clamp (* min_freq , devfreq -> scaling_min_freq , * max_freq );
160157}
161158EXPORT_SYMBOL (devfreq_get_freq_range );
162159
@@ -807,7 +804,6 @@ struct devfreq *devfreq_add_device(struct device *dev,
807804{
808805 struct devfreq * devfreq ;
809806 struct devfreq_governor * governor ;
810- unsigned long min_freq , max_freq ;
811807 int err = 0 ;
812808
813809 if (!dev || !profile || !governor_name ) {
@@ -835,6 +831,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
835831 mutex_lock (& devfreq -> lock );
836832 devfreq -> dev .parent = dev ;
837833 devfreq -> dev .class = devfreq_class ;
834+ devfreq -> dev .groups = profile -> dev_groups ;
838835 devfreq -> dev .release = devfreq_dev_release ;
839836 INIT_LIST_HEAD (& devfreq -> node );
840837 devfreq -> profile = profile ;
@@ -875,8 +872,6 @@ struct devfreq *devfreq_add_device(struct device *dev,
875872 goto err_dev ;
876873 }
877874
878- devfreq_get_freq_range (devfreq , & min_freq , & max_freq );
879-
880875 devfreq -> suspend_freq = dev_pm_opp_get_suspend_opp_freq (dev );
881876 devfreq -> opp_table = dev_pm_opp_get_opp_table (dev );
882877 if (IS_ERR (devfreq -> opp_table ))
@@ -1382,15 +1377,11 @@ int devfreq_remove_governor(struct devfreq_governor *governor)
13821377 int ret ;
13831378 struct device * dev = devfreq -> dev .parent ;
13841379
1380+ if (!devfreq -> governor )
1381+ continue ;
1382+
13851383 if (!strncmp (devfreq -> governor -> name , governor -> name ,
13861384 DEVFREQ_NAME_LEN )) {
1387- /* we should have a devfreq governor! */
1388- if (!devfreq -> governor ) {
1389- dev_warn (dev , "%s: Governor %s NOT present\n" ,
1390- __func__ , governor -> name );
1391- continue ;
1392- /* Fall through */
1393- }
13941385 ret = devfreq -> governor -> event_handler (devfreq ,
13951386 DEVFREQ_GOV_STOP , NULL );
13961387 if (ret ) {
@@ -1743,7 +1734,7 @@ static ssize_t trans_stat_show(struct device *dev,
17431734 for (i = 0 ; i < max_state ; i ++ ) {
17441735 if (len >= PAGE_SIZE - 1 )
17451736 break ;
1746- if (df -> freq_table [2 ] == df -> previous_freq )
1737+ if (df -> freq_table [i ] == df -> previous_freq )
17471738 len += sysfs_emit_at (buf , len , "*" );
17481739 else
17491740 len += sysfs_emit_at (buf , len , " " );
0 commit comments