Skip to content

Commit 9b0c651

Browse files
jgyu25broonie
authored andcommitted
ASoC: uniphier: Handle regmap_write errors in aio_iecout_set_enable()
The aio_oport_set_stream_type() function did not previously check the return values of regmap_write(). If these functions fail, it could lead to silent failures when configuring the audio playback port, causing improper behavior in audio stream output via S/PDIF without any indication of an error. This patch modifies aio_oport_set_stream_type() to check the return values of regmap_write(). If regmap_write() fails, the error code is propagated back to the caller to ensure proper error handling. Signed-off-by: Ingyu Jang <ingyujang25@unist.ac.kr> Link: https://patch.msgid.link/SE1P216MB2287962B462AE91B26248D19FD7E2@SE1P216MB2287.KORP216.PROD.OUTLOOK.COM Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 43aea89 commit 9b0c651

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

sound/soc/uniphier/aio-core.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -838,6 +838,7 @@ int aio_oport_set_stream_type(struct uniphier_aio_sub *sub,
838838
{
839839
struct regmap *r = sub->aio->chip->regmap;
840840
u32 repet = 0, pause = OPORTMXPAUDAT_PAUSEPC_CMN;
841+
int ret;
841842

842843
switch (pc) {
843844
case IEC61937_PC_AC3:
@@ -880,8 +881,13 @@ int aio_oport_set_stream_type(struct uniphier_aio_sub *sub,
880881
break;
881882
}
882883

883-
regmap_write(r, OPORTMXREPET(sub->swm->oport.map), repet);
884-
regmap_write(r, OPORTMXPAUDAT(sub->swm->oport.map), pause);
884+
ret = regmap_write(r, OPORTMXREPET(sub->swm->oport.map), repet);
885+
if (ret)
886+
return ret;
887+
888+
ret = regmap_write(r, OPORTMXPAUDAT(sub->swm->oport.map), pause);
889+
if (ret)
890+
return ret;
885891

886892
return 0;
887893
}

0 commit comments

Comments
 (0)