Skip to content

Commit 9f3d8e6

Browse files
committed
ASoC: Intel: atom: sst_ipc: remove redundant test
cppcheck warning: sound/soc/intel/atom/sst/sst_ipc.c:344:30: style: Condition 'drv_id' is always true [knownConditionTrueFalse] if (msg_high.part.result && drv_id && !msg_high.part.large) { ^ sound/soc/intel/atom/sst/sst_ipc.c:337:13: note: Assuming that condition 'drv_id==0' is not redundant if (drv_id == SST_ASYNC_DRV_ID) { ^ sound/soc/intel/atom/sst/sst_ipc.c:344:30: note: Condition 'drv_id' is always true if (msg_high.part.result && drv_id && !msg_high.part.large) { ^ Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
1 parent 8d0041d commit 9f3d8e6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/intel/atom/sst/sst_ipc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ void sst_process_reply_mrfld(struct intel_sst_drv *sst_drv_ctx,
341341
}
342342

343343
/* FW sent short error response for an IPC */
344-
if (msg_high.part.result && drv_id && !msg_high.part.large) {
344+
if (msg_high.part.result && !msg_high.part.large) {
345345
/* 32-bit FW error code in msg_low */
346346
dev_err(sst_drv_ctx->dev, "FW sent error response 0x%x", msg_low);
347347
sst_wake_up_block(sst_drv_ctx, msg_high.part.result,

0 commit comments

Comments
 (0)