Skip to content

Commit a1d14d8

Browse files
Chen Nibroonie
authored andcommitted
ASoC: codecs: max98390: Check return value of devm_gpiod_get_optional() in max98390_i2c_probe()
The devm_gpiod_get_optional() function may return an error pointer (ERR_PTR) in case of a genuine failure during GPIO acquisition, not just NULL which indicates the legitimate absence of an optional GPIO. Add an IS_ERR() check after the function call to catch such errors and propagate them to the probe function, ensuring the driver fails to load safely rather than proceeding with an invalid pointer. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Link: https://patch.msgid.link/20260130091904.3426149-1-nichen@iscas.ac.cn Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent bbb758a commit a1d14d8

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

sound/soc/codecs/max98390.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,6 +1067,9 @@ static int max98390_i2c_probe(struct i2c_client *i2c)
10671067

10681068
reset_gpio = devm_gpiod_get_optional(&i2c->dev,
10691069
"reset", GPIOD_OUT_HIGH);
1070+
if (IS_ERR(reset_gpio))
1071+
return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio),
1072+
"Failed to get reset gpio\n");
10701073

10711074
/* Power on device */
10721075
if (reset_gpio) {

0 commit comments

Comments
 (0)