Skip to content

Commit a3d8f73

Browse files
Srinivas Kandagatlabroonie
authored andcommitted
ASoC: codecs: wcd934x: add explicit soundwire depenency
WCD934x provides register read/write interface to soundwire controller via slimbus. Eventhough there was no direct compile time dependency for this so far, however after adding common wcd functions this dependency became explict. We can either move the soundwire specific bits from wcd-common to wcd-sdw.c or something on those lines or explicity add this dependency in Kconfig. Moving this wcd-sdw can fix reported compile issue but it does not make sense to select this codec without soundwire configs. Given the fact that WCD934x is very much providing soundwire functionality it is better to specify the soundwire dependency explicity in Kconfig which should also fix the below compile time error with combination of wcd934x a built-in and soundwire a module and also allow this codec selection only when soundwire is available. Error log: wcd-common.c:undefiined reference to `sdw_write' sound/soc/codecs/wcd-common.o: in function `wcd_bus_config': Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202511210405.zd9wig5Z-lkp@intel.com/ Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Link: https://patch.msgid.link/20251121143258.229138-1-srinivas.kandagatla@oss.qualcomm.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 2bae7be commit a3d8f73

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

sound/soc/codecs/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2310,6 +2310,7 @@ config SND_SOC_WCD934X
23102310
tristate "WCD9340/WCD9341 Codec"
23112311
depends on COMMON_CLK
23122312
depends on SLIMBUS
2313+
depends on SOUNDWIRE || !SOUNDWIRE
23132314
select REGMAP_IRQ
23142315
select REGMAP_SLIMBUS
23152316
select SND_SOC_WCD_CLASSH

0 commit comments

Comments
 (0)