Skip to content

Commit a48a6fb

Browse files
committed
ASoC: SOF: debug/ipc: Treat IPC tx timeout as feature, not failure
Do not set the firmware state as crashed on IPC tx timeout as it looks to be something which happens on a regular basis. The dumps are 'muted' after the first print but if consequent IPC tx succeeds we should enable them again as the timeout was just a hiccup on the firmware side. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
1 parent 61307de commit a48a6fb

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

sound/soc/sof/debug.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,6 @@ void snd_sof_handle_fw_exception(struct snd_sof_dev *sdev)
865865
/* dump vital information to the logs */
866866
snd_sof_ipc_dump(sdev);
867867
snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX);
868-
sof_set_fw_state(sdev, SOF_FW_CRASHED);
869868
snd_sof_trace_notify_for_error(sdev);
870869
}
871870
EXPORT_SYMBOL(snd_sof_handle_fw_exception);

sound/soc/sof/ipc.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,12 @@ static int tx_wait_done(struct snd_sof_ipc *ipc, struct snd_sof_ipc_msg *msg,
267267
memcpy(reply_data, msg->reply_data,
268268
msg->reply_size);
269269
}
270+
271+
/* re-enable dumps after succeesful IPC tx */
272+
if (sdev->ipc_dump_printed) {
273+
sdev->dbg_dump_printed = false;
274+
sdev->ipc_dump_printed = false;
275+
}
270276
}
271277

272278
return ret;

0 commit comments

Comments
 (0)