Skip to content

Commit bb4ff9c

Browse files
committed
Revert "ACPI: scan: Do not add device IDs from _CID if _HID is not valid"
This reverts commit e38f9ff. Suspend-resume regressions were noticed on Intel TGLU_RVP and CML Helios Chromebook. Excert from discussion with ACPI maintainer in from #3521 (comment): Commit e38f9ff ("ACPI: scan: Do not add device IDs from _CID if _HID is not valid") is going to be reverted, because it caused multiple systems to misbehave as per the below. BugLink: #3459 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
1 parent d293750 commit bb4ff9c

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/acpi/scan.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1377,11 +1377,11 @@ static void acpi_set_pnp_ids(acpi_handle handle, struct acpi_device_pnp *pnp,
13771377
if (info->valid & ACPI_VALID_HID) {
13781378
acpi_add_id(pnp, info->hardware_id.string);
13791379
pnp->type.platform_id = 1;
1380-
if (info->valid & ACPI_VALID_CID) {
1381-
cid_list = &info->compatible_id_list;
1382-
for (i = 0; i < cid_list->count; i++)
1383-
acpi_add_id(pnp, cid_list->ids[i].string);
1384-
}
1380+
}
1381+
if (info->valid & ACPI_VALID_CID) {
1382+
cid_list = &info->compatible_id_list;
1383+
for (i = 0; i < cid_list->count; i++)
1384+
acpi_add_id(pnp, cid_list->ids[i].string);
13851385
}
13861386
if (info->valid & ACPI_VALID_ADR) {
13871387
pnp->bus_address = info->address;

0 commit comments

Comments
 (0)