ASoC: mxs-sgtl5000: disable MCLK on error paths of mxs_sgtl5000_probe()

Haoxiang Li · broonie · commit c8ef13d692f1 · 2026-04-01T14:01:25.000+01:00
Call mxs_saif_put_mclk() to disable MCLK on error paths of mxs_sgtl5000_probe(). Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn> Link: https://patch.msgid.link/20260401053051.586290-1-lihaoxiang@isrc.iscas.ac.cn Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c
@@ -157,13 +157,16 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev)
 		if (ret) {
 			dev_err(&pdev->dev, "failed to parse audio-routing (%d)\n",
 				ret);
+			mxs_saif_put_mclk(0);
 			return ret;
 		}
 	}
 
 	ret = devm_snd_soc_register_card(&pdev->dev, card);
-	if (ret)
+	if (ret) {
+		mxs_saif_put_mclk(0);
 		return dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n");
+	}
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -157,13 +157,16 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev)`
`157`	`157`	`if (ret) {`
`158`	`158`	`dev_err(&pdev->dev, "failed to parse audio-routing (%d)\n",`
`159`	`159`	`ret);`
	`160`	`+ mxs_saif_put_mclk(0);`
`160`	`161`	`return ret;`
`161`	`162`	`}`
`162`	`163`	`}`
`163`	`164`
`164`	`165`	`ret = devm_snd_soc_register_card(&pdev->dev, card);`
`165`		`- if (ret)`
	`166`	`+ if (ret) {`
	`167`	`+ mxs_saif_put_mclk(0);`
`166`	`168`	`return dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n");`
	`169`	`+ }`
`167`	`170`
`168`	`171`	`return 0;`
`169`	`172`	`}`