Skip to content

Commit d248b27

Browse files
imtangmengtiwai
authored andcommitted
sound: core: remove initialise static variables to 0
Initializing the static variable to 0 causes the following error when exec checkpatch: ERROR: do not initialise statics to 0 FILE: sound/sound_core.c:142: static int preclaim_oss = 0; In addition, considering the following way of writing 139: #ifdef config_sound_oss_core_preclaim 140: Static int preclaim_oss = 1; 141: #ELSE 142: Static int preclaim_oss = 0; 143: #ENDIF We can optimize it by IS_ENABLED(CONFIG_SOUND_OSS_CORE_PRECLAIM), so modified it to static int preclaim_oss = IS_ENABLED(CONFIG_SOUND_OSS_CORE_PRECLAIM); Signed-off-by: Meng Tang <tangmeng@uniontech.com> Link: https://lore.kernel.org/r/20220228050253.1649-1-tangmeng@uniontech.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent ca1697e commit d248b27

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

sound/sound_core.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,7 @@ struct sound_unit
136136
* All these clutters are scheduled to be removed along with
137137
* sound-slot/service-* module aliases.
138138
*/
139-
#ifdef CONFIG_SOUND_OSS_CORE_PRECLAIM
140-
static int preclaim_oss = 1;
141-
#else
142-
static int preclaim_oss = 0;
143-
#endif
139+
static int preclaim_oss = IS_ENABLED(CONFIG_SOUND_OSS_CORE_PRECLAIM);
144140

145141
module_param(preclaim_oss, int, 0444);
146142

0 commit comments

Comments
 (0)