Skip to content

Commit d559335

Browse files
jonhunterrafaeljw
authored andcommitted
ucsi_ccg: Disable async suspend in ucsi_ccg_probe()
Commit aa7a927 ("PM: sleep: Suspend async parents after suspending children") had triggered a suspend issue on Tegra boards because it had reordered the syspend of devices with async suspend enabled with respect to some other devices. Specifically, the devices with async suspend enabled that have no children are now suspended before any other devices unless there are device links pointing to them as suppliers. The investigation that followed the failure report uncovered that async suspend was enabled for the cypd4226 device that was a Type-C controller with a dependency on USB PHY and it turned out that disabling async suspend for that device made the issue go away. Since async suspend takes dependencies between parents and children into account as well as other dependencies between devices represented by device links, this means that the cypd4226 has a dependency on another device that is not represented in any form in the kernel (a "hidden" dependency), in which case async suspend should not be enabled for it. Accordingly, make ucsi_ccg_probe() disable async suspend for the devices handled by, which covers the cypd4226 device on the Tegra boards as well as other devices likely to have similar "hidden" dependencies. Fixes: aa7a927 ("PM: sleep: Suspend async parents after suspending children") Closes: https://lore.kernel.org/linux-pm/c6cd714b-b0eb-42fc-b9b5-4f5f396fb4ec@nvidia.com/ Reported-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://patch.msgid.link/6180608.lOV4Wx5bFT@rjwysocki.net
1 parent 50c9bb3 commit d559335

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/usb/typec/ucsi/ucsi_ccg.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1483,6 +1483,8 @@ static int ucsi_ccg_probe(struct i2c_client *client)
14831483

14841484
i2c_set_clientdata(client, uc);
14851485

1486+
device_disable_async_suspend(uc->dev);
1487+
14861488
pm_runtime_set_active(uc->dev);
14871489
pm_runtime_enable(uc->dev);
14881490
pm_runtime_use_autosuspend(uc->dev);

0 commit comments

Comments
 (0)