Skip to content

Commit e2f12b3

Browse files
ujfalusiplbossart
authored andcommitted
ASoC: SOF: ipc3-dtrace: Move host ops wrappers from generic header to private
Move the snd_sof_dma_trace_* ops wrappers from ops.h to ipc3-priv.h since they are not used outside of IPC3 code. While moving, rename them to sof_dtrace_host_* Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
1 parent a80343f commit e2f12b3

3 files changed

Lines changed: 37 additions & 31 deletions

File tree

sound/soc/sof/ipc3-dtrace.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev)
411411
sdev->host_offset = 0;
412412
sdev->dtrace_draining = false;
413413

414-
ret = snd_sof_dma_trace_init(sdev, &params);
414+
ret = sof_dtrace_host_init(sdev, &params);
415415
if (ret < 0) {
416416
dev_err(sdev->dev, "Host dtrace init failed: %d\n", ret);
417417
return ret;
@@ -426,7 +426,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev)
426426
}
427427

428428
start:
429-
ret = snd_sof_dma_trace_trigger(sdev, SNDRV_PCM_TRIGGER_START);
429+
ret = sof_dtrace_host_trigger(sdev, SNDRV_PCM_TRIGGER_START);
430430
if (ret < 0) {
431431
dev_err(sdev->dev, "Host dtrace trigger start failed: %d\n", ret);
432432
goto trace_release;
@@ -437,7 +437,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev)
437437
return 0;
438438

439439
trace_release:
440-
snd_sof_dma_trace_release(sdev);
440+
sof_dtrace_host_release(sdev);
441441
return ret;
442442
}
443443

@@ -540,7 +540,7 @@ static void ipc3_dtrace_release(struct snd_sof_dev *sdev, bool only_stop)
540540
if (!sdev->fw_trace_is_supported || sdev->dtrace_state == SOF_DTRACE_DISABLED)
541541
return;
542542

543-
ret = snd_sof_dma_trace_trigger(sdev, SNDRV_PCM_TRIGGER_STOP);
543+
ret = sof_dtrace_host_trigger(sdev, SNDRV_PCM_TRIGGER_STOP);
544544
if (ret < 0)
545545
dev_err(sdev->dev, "Host dtrace trigger stop failed: %d\n", ret);
546546
sdev->dtrace_state = SOF_DTRACE_STOPPED;
@@ -562,7 +562,7 @@ static void ipc3_dtrace_release(struct snd_sof_dev *sdev, bool only_stop)
562562
if (only_stop)
563563
goto out;
564564

565-
ret = snd_sof_dma_trace_release(sdev);
565+
ret = sof_dtrace_host_release(sdev);
566566
if (ret < 0)
567567
dev_err(sdev->dev, "Host dtrace release failed %d\n", ret);
568568

sound/soc/sof/ipc3-priv.h

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,36 @@ int sof_ipc3_validate_fw_version(struct snd_sof_dev *sdev);
2929
int ipc3_dtrace_posn_update(struct snd_sof_dev *sdev,
3030
struct sof_ipc_dma_trace_posn *posn);
3131

32+
/* dtrace platform callback wrappers */
33+
static inline int sof_dtrace_host_init(struct snd_sof_dev *sdev,
34+
struct sof_ipc_dma_trace_params_ext *dtrace_params)
35+
{
36+
struct snd_sof_dsp_ops *dsp_ops = sdev->pdata->desc->ops;
37+
38+
if (dsp_ops->trace_init)
39+
return dsp_ops->trace_init(sdev, dtrace_params);
40+
41+
return 0;
42+
}
43+
44+
static inline int sof_dtrace_host_release(struct snd_sof_dev *sdev)
45+
{
46+
struct snd_sof_dsp_ops *dsp_ops = sdev->pdata->desc->ops;
47+
48+
if (dsp_ops->trace_release)
49+
return dsp_ops->trace_release(sdev);
50+
51+
return 0;
52+
}
53+
54+
static inline int sof_dtrace_host_trigger(struct snd_sof_dev *sdev, int cmd)
55+
{
56+
struct snd_sof_dsp_ops *dsp_ops = sdev->pdata->desc->ops;
57+
58+
if (dsp_ops->trace_trigger)
59+
return dsp_ops->trace_trigger(sdev, cmd);
60+
61+
return 0;
62+
}
63+
3264
#endif

sound/soc/sof/ops.h

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -381,32 +381,6 @@ static inline int snd_sof_dsp_send_msg(struct snd_sof_dev *sdev,
381381
return sof_ops(sdev)->send_msg(sdev, msg);
382382
}
383383

384-
/* host DMA trace */
385-
static inline int snd_sof_dma_trace_init(struct snd_sof_dev *sdev,
386-
struct sof_ipc_dma_trace_params_ext *dtrace_params)
387-
{
388-
if (sof_ops(sdev)->trace_init)
389-
return sof_ops(sdev)->trace_init(sdev, dtrace_params);
390-
391-
return 0;
392-
}
393-
394-
static inline int snd_sof_dma_trace_release(struct snd_sof_dev *sdev)
395-
{
396-
if (sof_ops(sdev)->trace_release)
397-
return sof_ops(sdev)->trace_release(sdev);
398-
399-
return 0;
400-
}
401-
402-
static inline int snd_sof_dma_trace_trigger(struct snd_sof_dev *sdev, int cmd)
403-
{
404-
if (sof_ops(sdev)->trace_trigger)
405-
return sof_ops(sdev)->trace_trigger(sdev, cmd);
406-
407-
return 0;
408-
}
409-
410384
/* host PCM ops */
411385
static inline int
412386
snd_sof_pcm_platform_open(struct snd_sof_dev *sdev,

0 commit comments

Comments
 (0)