ksmbd: ensure error is surfaced in set_file_basic_info()

Christian Brauner · smfrench · commit eb5784f0c6ef · 2021-09-03T23:29:45.000-05:00
It seems the error was accidently ignored until now. Make sure it is
surfaced.

Cc: Steve French &lt;stfrench@microsoft.com&gt;
Cc: Christoph Hellwig &lt;hch@infradead.org&gt;
Cc: Namjae Jeon &lt;namjae.jeon@samsung.com&gt;
Cc: Hyunchul Lee &lt;hyc.lee@gmail.com&gt;
Cc: Sergey Senozhatsky &lt;senozhatsky@chromium.org&gt;
Cc: linux-cifs@vger.kernel.org
Signed-off-by: Christian Brauner &lt;christian.brauner@ubuntu.com&gt;
Signed-off-by: Namjae Jeon &lt;linkinjeon@kernel.org&gt;
Signed-off-by: Steve French &lt;stfrench@microsoft.com&gt;
diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
@@ -5531,7 +5531,7 @@ static int set_file_basic_info(struct ksmbd_file *fp, char *buf,
 		rc = notify_change(user_ns, dentry, &attrs, NULL);
 		inode_unlock(inode);
 	}
-	return 0;
+	return rc;
 }
 
 static int set_file_allocation_info(struct ksmbd_work *work,

Original file line number	Diff line number	Diff line change
`@@ -5531,7 +5531,7 @@ static int set_file_basic_info(struct ksmbd_file fp, char buf,`
`5531`	`5531`	`rc = notify_change(user_ns, dentry, &attrs, NULL);`
`5532`	`5532`	`inode_unlock(inode);`
`5533`	`5533`	`}`
`5534`		`- return 0;`
	`5534`	`+ return rc;`
`5535`	`5535`	`}`
`5536`	`5536`
`5537`	`5537`	`static int set_file_allocation_info(struct ksmbd_work *work,`