Skip to content

Commit 0bb4b66

Browse files
committed
sof-dump-status.py: make -s, -i and -l fail on wrong card numbers
Yet another green failure. Passing a wrong card number now fails as expected: ./tools/sof-dump-status.py -i 42 >/dev/null Traceback (most recent call last): File "./tools/sof-dump-status.py", line 487, in <module> card_info = sysinfo.proc_card[str(ret_args['id'])] KeyError: '42' Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent 5bb6679 commit 0bb4b66

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

tools/sof-dump-status.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -484,25 +484,19 @@ def dump_dapm(dapm, filter = "all"):
484484

485485
if ret_args.get('id') is not None:
486486
sysinfo.loadProcSound()
487-
card_info = sysinfo.proc_card.get(str(ret_args['id']))
488-
if card_info is None:
489-
exit(0)
487+
card_info = sysinfo.proc_card[str(ret_args['id'])]
490488
dump_cardinfo_pcm(card_info)
491489
exit(0)
492490

493491
if ret_args.get('short') is not None:
494492
sysinfo.loadProcSound()
495-
card_info = sysinfo.proc_card.get(str(ret_args['short']))
496-
if card_info is None:
497-
exit(0)
493+
card_info = sysinfo.proc_card[str(ret_args['short'])]
498494
print(card_info['short'])
499495
exit(0)
500496

501497
if ret_args.get('longname') is not None:
502498
sysinfo.loadProcSound()
503-
card_info = sysinfo.proc_card.get(str(ret_args['longname']))
504-
if card_info is None:
505-
exit(0)
499+
card_info = sysinfo.proc_card[str(ret_args['longname'])]
506500
print(card_info['longname'])
507501
exit(0)
508502

0 commit comments

Comments
 (0)