Skip to content

Commit 65d7174

Browse files
committed
check-ipc-flood.sh: stop asking IPC4 users to use CONFIG_DEBUG
Add is_ipc4() call and a new SKIP message to stop telling Zephyr users to build a "debug firmware" because it won't change anything for them: IPC4 has no flood command right now, see #1066 Also clarify the XTOS skip message + other cosmetic improvements. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent 000633a commit 65d7174

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

test-case/check-ipc-flood.sh

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,21 @@ loop_cnt=${OPT_VAL['l']}
3636

3737
start_test
3838

39+
if is_ipc4; then
40+
skip_test 'IPC4 detected: see sof-test#1066'
41+
fi
42+
43+
# See SOF_IPC_INFO_BUILD in linux/sound/soc/sof/ipc3.c:sof_ipc3_validate_fw_version()
3944
sof-kernel-dump.sh | grep sof-audio | grep -q "Firmware debug" ||
40-
skip_test "need debug version firmware"
45+
skip_test "CONFIG_DEBUG firmware needed for SOF_IPC_TEST_IPC_FLOOD cmd"
4146

4247
func_lib_check_sudo
4348

44-
dlogi "Check sof debug fs environment"
45-
if sudo file $ipc_flood_dfs | grep 'No such file'; then
49+
dlogi "Check $ipc_flood_dfs"
50+
sudo test -e $ipc_flood_dfs ||
4651
skip_test "${BASH_SOURCE[0]} need $ipc_flood_dfs to run the test case"
47-
fi
48-
dlogi "Checking ipc flood test!"
52+
53+
dlogi "Running ipc flood test!"
4954

5055
for i in $(seq 1 $loop_cnt)
5156
do

0 commit comments

Comments
 (0)