Skip to content

Commit 01100e5

Browse files
committed
uapi: ipc: align with kernel
It beats me why changes done one one side are not merged on the other. We should really require all changes to the IPC files to be distinct PRs so that they are easier to track. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
1 parent 597194f commit 01100e5

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

src/include/uapi/ipc.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
#define SOF_IPC_TRACE_DMA_POSITION SOF_CMD_TYPE(0x002)
127127

128128
/* Get message component id */
129-
#define SOF_IPC_MESSAGE_ID(x) (x & 0xffff)
129+
#define SOF_IPC_MESSAGE_ID(x) ((x) & 0xffff)
130130

131131
/* maximum message size for mailbox Tx/Rx */
132132
#define SOF_IPC_MSG_MAX_SIZE 128
@@ -240,7 +240,6 @@ struct sof_ipc_compound_hdr {
240240
#define SOF_DAI_INTEL_SSP_QUIRK_PSPSRWFDFD (1 << 5)
241241
/* here is the possibility to define others aux macros */
242242

243-
244243
#define SOF_DAI_INTEL_SSP_FRAME_PULSE_WIDTH_MAX 38
245244

246245
/** \brief Types of DAI */
@@ -347,13 +346,13 @@ struct sof_ipc_dai_dmic_params {
347346
uint32_t pdmclk_max; /* Maximum microphone clock in Hz (min...N) */
348347
uint32_t fifo_fs_a; /* FIFO A sample rate in Hz (8000..96000) */
349348
uint32_t fifo_fs_b; /* FIFO B sample rate in Hz (8000..96000) */
350-
/* TODO: FIFO word lengths can be retrieved from SOF_DAI_FMT */
351349
uint16_t fifo_bits_a; /* FIFO A word length (16 or 32) */
352350
uint16_t fifo_bits_b; /* FIFO B word length (16 or 32) */
353351
uint16_t duty_min; /* Min. mic clock duty cycle in % (20..80) */
354352
uint16_t duty_max; /* Max. mic clock duty cycle in % (min..80) */
355-
uint32_t num_pdm_active; /* Number of active controllers */
356-
struct sof_ipc_dai_dmic_pdm_ctrl pdm[];
353+
uint32_t num_pdm_active; /* Number of active pdm controllers */
354+
/* variable number of pdm controller config */
355+
struct sof_ipc_dai_dmic_pdm_ctrl pdm[0];
357356
} __attribute__((packed));
358357

359358
/* general purpose DAI configuration */

0 commit comments

Comments
 (0)