lib_manager: Align native_system_agent_start return value

Change the signature of the native_system_agent_start function to match
with the system_agent_start function. The function returns an error code
and a pointer to the module interface is returned via the parameter.

Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

Author: softwarecki

src/audio/module_adapter/library/native_system_agent.c

@@ -19,17 +19,24 @@ typedef void* (*native_create_instance_f)(void *mod_cfg, void *parent_ppl,
 
 struct native_system_agent native_sys_agent;
 
-void *native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
-				uint32_t core_id, uint32_t log_handle, void *mod_cfg)
+int native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
+			      uint32_t core_id, uint32_t log_handle, void *mod_cfg,
+			      const void **iface)
 {
 	native_sys_agent.module_id = module_id;
 	native_sys_agent.instance_id = instance_id;
 	native_sys_agent.core_id = core_id;
 	native_sys_agent.log_handle = log_handle;
+	const void *ret;
 
 	void *system_agent_p = &native_sys_agent;
 
 	native_create_instance_f ci = (native_create_instance_f)entry_point;
 
-	return ci(mod_cfg, NULL, &system_agent_p);
+	ret = ci(mod_cfg, NULL, &system_agent_p);
+	if (!ret)
+		return -EINVAL;
+
+	*iface = ret;
+	return 0;
 }

src/include/sof/audio/module_adapter/library/native_system_agent.h

@@ -20,7 +20,23 @@ struct native_system_agent {
 	uint32_t module_size;
 };
 
-void *native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
-				uint32_t core_id, uint32_t log_handle, void *mod_cfg);
+/**
+ * @brief Starts the native system agent.
+ *
+ * This function initializes and starts the native system agent with the provided parameters.
+ *
+ * @param[in] entry_point - The module entry point function address.
+ * @param[in] module_id - The identifier for the module.
+ * @param[in] instance_id - The instance identifier of the module.
+ * @param[in] core_id - Core on which the module will run.
+ * @param[in] log_handle - The handle for logging purposes.
+ * @param[in] mod_cfg - Pointer to the module configuration data.
+ * @param[out] iface - Pointer to the module interface.
+ *
+ * @return Returns 0 on success or an error code on failure.
+ */
+int native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
+			      uint32_t core_id, uint32_t log_handle, void *mod_cfg,
+			      const void **iface);
 
 #endif /* __NATIVE_SYSTEM_AGENT_H__ */

src/library_manager/lib_manager.c

@@ -496,7 +496,9 @@ static struct comp_dev *lib_manager_module_create(const struct comp_driver *drv,
 	const uint32_t module_id = IPC4_MOD_ID(config->id);
 	const uint32_t instance_id = IPC4_INST_ID(config->id);
 	const uint32_t log_handle = (uint32_t)drv->tctx;
+	const struct module_interface *ops;
 	byte_array_t mod_cfg;
+	int ret;
 
 	/*
 	 * Variable used by llext_manager to temporary store llext handle before creation
@@ -518,11 +520,9 @@ static struct comp_dev *lib_manager_module_create(const struct comp_driver *drv,
 	/* Intel modules expects DW size here */
 	mod_cfg.size = args->size >> 2;
 
-	const struct module_interface *ops = native_system_agent_start(module_entry_point,
-								       module_id, instance_id,
-								       0, log_handle, &mod_cfg);
-
-	if (!ops) {
+	ret = native_system_agent_start(module_entry_point, module_id, instance_id, 0, log_handle,
+					&mod_cfg, (const void **)&ops);
+	if (ret) {
 		lib_manager_free_module(module_id);
 		tr_err(&lib_manager_tr, "native_system_agent_start failed!");
 		return NULL;