lib_manager: Fix memory leak in lib_manager_register_module

softwarecki · lgirdwood · commit 6ac84d435fbc · 2025-04-11T13:23:28.000+01:00
Free allocated driver structure when an unsupported loadable module api
version is detected.

Signed-off-by: Adrian Warecki &lt;adrian.warecki@intel.com&gt;
diff --git a/src/library_manager/lib_manager.c b/src/library_manager/lib_manager.c
@@ -654,7 +654,8 @@ int lib_manager_register_module(const uint32_t component_id)
 			if (build_info->format != SOF_MODULE_API_BUILD_INFO_FORMAT ||
 			    build_info->api_version_number.full != SOF_MODULE_API_CURRENT_VERSION) {
 				tr_err(&lib_manager_tr, "Unsupported module API version");
-				return -ENOEXEC;
+				ret = -ENOEXEC;
+				goto cleanup;
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -654,7 +654,8 @@ int lib_manager_register_module(const uint32_t component_id)`
`654`	`654`	`if (build_info->format != SOF_MODULE_API_BUILD_INFO_FORMAT \|\|`
`655`	`655`	`build_info->api_version_number.full != SOF_MODULE_API_CURRENT_VERSION) {`
`656`	`656`	`tr_err(&lib_manager_tr, "Unsupported module API version");`
`657`		`- return -ENOEXEC;`
	`657`	`+ ret = -ENOEXEC;`
	`658`	`+ goto cleanup;`
`658`	`659`	`}`
`659`	`660`	`}`
`660`	`661`	`}`