Skip to content

Commit af19236

Browse files
authored
Merge pull request #486 from dabekjakub/fix_pause_resume
dma: fixed play pause bug
2 parents 1024e94 + 5cb14b3 commit af19236

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/drivers/intel/cavs/hda-dma.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
#include <arch/cache.h>
5151
#include <uapi/ipc.h>
5252

53-
#define trace_host(__e) trace_event(TRACE_CLASS_HOST, __e)
53+
#define trace_host(__e, ...) \
54+
trace_event(TRACE_CLASS_HOST, __e, ##__VA_ARGS__)
5455
#define tracev_host(__e) tracev_event(TRACE_CLASS_HOST, __e)
5556
#define trace_host_error(__e) trace_error(TRACE_CLASS_HOST, __e)
5657

@@ -396,16 +397,15 @@ static int hda_dma_start(struct dma *dma, int channel)
396397

397398
static int hda_dma_release(struct dma *dma, int channel)
398399
{
399-
/* TODO: to be removed, no longer called by anyone */
400-
struct dma_pdata *p = dma_get_drvdata(dma);
400+
/* Implementation left for future alignment
401+
*of dma pointers (if needed)
402+
*/
401403
uint32_t flags;
402404

403405
spin_lock_irq(&dma->lock, flags);
404406

405-
trace_host("Dpr");
406-
407-
/* resume and reload DMA */
408-
p->chan[channel].status = COMP_STATE_ACTIVE;
407+
trace_host("hda-dma-release dma-ptr: %p channel-number: %u",
408+
(uint32_t)dma, channel);
409409

410410
spin_unlock_irq(&dma->lock, flags);
411411
return 0;

0 commit comments

Comments
 (0)