Skip to content

Commit c4a9cca

Browse files
authored
Merge pull request #105 from thesofproject/lrg/gcc-fixes
gcc build fixes for configure/libtool
2 parents 295d0c1 + 7920409 commit c4a9cca

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

configure.ac

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ AC_DEFINE_UNQUOTED([SOF_MICRO], sof_micro, [Sof micro version])
1818

1919
AC_CANONICAL_HOST
2020

21-
# General compiler flags
22-
CFLAGS="${CFLAGS:+$CFLAGS } -O2 -g -Wall -Werror -Wl,-EL -Wmissing-prototypes"
23-
2421
# General assembler flags
2522
ASFLAGS="-DASSEMBLY"
2623
AC_SUBST(ASFLAGS)
@@ -68,6 +65,7 @@ AM_CONDITIONAL(BUILD_LIB, test "$have_library" = "yes")
6865
AC_ARG_ENABLE(rimage, [AS_HELP_STRING([--enable-rimage],[build rimage tool])], have_rimage=$enableval, have_rimage=no)
6966
if test "$have_rimage" = "yes"; then
7067
AC_DEFINE([CONFIG_RIMAGE], [1], [Configure to build rimage])
68+
AM_CFLAGS="-O2 -g -Wall -Werror -Wl,-EL -Wmissing-prototypes"
7169
fi
7270
AM_CONDITIONAL(BUILD_RIMAGE, test "$have_rimage" = "yes")
7371

@@ -94,6 +92,11 @@ case "$with_arch" in
9492
AM_LDFLAGS="-nostdlib"
9593
AM_CCASFLAGS="-fno-inline-functions -nostdlib -mlongcalls"
9694

95+
# GCC needs these additional flags on top of any user flags.
96+
CFLAGS="${CFLAGS:+$CFLAGS } -O2 -g -Wall -Werror -Wl,-EL -Wmissing-prototypes"
97+
LDFLAGS="${LDFLAGS:+$LDFLAGS } ${AM_LDFLAGS}"
98+
CCASFLAGS="${CCASFLAGS:+$CCASFLAGS } ${AM_CCASFLAGS}"
99+
97100
ARCH="xtensa"
98101
AC_SUBST(ARCH)
99102

@@ -107,9 +110,9 @@ case "$with_arch" in
107110
ARCH_CFLAGS="-g"
108111

109112
# automake FLAGS defined here
110-
AM_CFLAGS="-O3"
113+
AM_CFLAGS="-O3 -Wall -Werror -Wl,-EL -Wmissing-prototypes"
111114
AM_LDFLAGS="-lpthread"
112-
AM_CCASFLAGS="-O3"
115+
AM_CCASFLAGS="-O3 -Wall -Werror -Wl,-EL -Wmissing-prototypes"
113116

114117
ARCH="host"
115118
AC_SUBST(ARCH)

src/audio/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ if BUILD_HOST
6464
# common linker flags for host libs
6565
host_lib_ldflags = \
6666
$(AM_LDFLAGS) \
67-
-version-info `echo $(VERSION) | cut -d '.' -f 1` \
67+
-version-info `echo $(VERSION) | cut -d '.' -f 1 | cut -d '0' -f 2` \
6868
-no-undefined \
6969
-export-dynamic
7070

src/ipc/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ libsof_ipc_la_SOURCES = \
66

77
libsof_ipc_la_LDFLAGS = \
88
$(AM_LDFLAGS) \
9-
-version-info `echo $(VERSION) | cut -d '.' -f 1` \
9+
-version-info `echo $(VERSION) | cut -d '.' -f 1 | cut -d '0' -f 2` \
1010
-no-undefined \
1111
-export-dynamic
1212

0 commit comments

Comments
 (0)