Skip to content

Commit c7b6bdb

Browse files
lyakhlgirdwood
authored andcommitted
audio: remove function names from logging calls (4/8)
Remove verbatim function names for aria, dcblock, smart_amp, copier, selector. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
1 parent a27e3c8 commit c7b6bdb

5 files changed

Lines changed: 79 additions & 79 deletions

File tree

src/audio/aria/aria.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ static int aria_init(struct processing_module *mod)
139139
att = aria->attenuation;
140140

141141
if (aria->attenuation > ARIA_MAX_ATT) {
142-
comp_warn(dev, "init_aria(): Attenuation value %d must not be greater than %d",
142+
comp_warn(dev, "Attenuation value %d must not be greater than %d",
143143
att, ARIA_MAX_ATT);
144144
att = ARIA_MAX_ATT;
145145
}
@@ -149,7 +149,7 @@ static int aria_init(struct processing_module *mod)
149149

150150
if (!buf) {
151151
rfree(cd);
152-
comp_err(dev, "init_aria(): allocation failed for size %d", req_mem);
152+
comp_err(dev, "allocation failed for size %d", req_mem);
153153
return -ENOMEM;
154154
}
155155

@@ -201,12 +201,12 @@ static int aria_prepare(struct processing_module *mod,
201201

202202
if (audio_stream_get_valid_fmt(&source->stream) != SOF_IPC_FRAME_S24_4LE ||
203203
audio_stream_get_valid_fmt(&sink->stream) != SOF_IPC_FRAME_S24_4LE) {
204-
comp_err(dev, "aria_prepare(): format is not supported");
204+
comp_err(dev, "format is not supported");
205205
return -EINVAL;
206206
}
207207

208208
if (dev->state == COMP_STATE_ACTIVE) {
209-
comp_info(dev, "aria_prepare(): Component is in active state.");
209+
comp_info(dev, "Component is in active state.");
210210
return 0;
211211
}
212212

@@ -291,7 +291,7 @@ static int aria_set_config(struct processing_module *mod, uint32_t param_id,
291291
memcpy_s(&cd->att, sizeof(uint32_t), fragment, sizeof(uint32_t));
292292
if (cd->att > ARIA_MAX_ATT) {
293293
comp_warn(dev,
294-
"aria_set_config(): Attenuation parameter %d is limited to %d",
294+
"Attenuation parameter %d is limited to %d",
295295
cd->att, ARIA_MAX_ATT);
296296
cd->att = ARIA_MAX_ATT;
297297
}

src/audio/copier/copier_ipcgtw.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ int copier_ipcgtw_process(const struct ipc4_ipcgtw_cmd *cmd,
102102
if (!dev)
103103
return -ENODEV;
104104

105-
comp_dbg(dev, "copier_ipcgtw_process(): %x %x",
105+
comp_dbg(dev, "%x %x",
106106
cmd->primary.dat, cmd->extension.dat);
107107

108108
buf = get_buffer(dev);
@@ -113,7 +113,7 @@ int copier_ipcgtw_process(const struct ipc4_ipcgtw_cmd *cmd,
113113
* case do not report error but return 0 bytes available for GET_DATA and
114114
* 0 bytes free for SET_DATA.
115115
*/
116-
comp_warn(dev, "copier_ipcgtw_process(): no buffer found");
116+
comp_warn(dev, "no buffer found");
117117
}
118118

119119
out = (struct ipc4_ipc_gateway_cmd_data_reply *)reply_payload;
@@ -162,7 +162,7 @@ int copier_ipcgtw_process(const struct ipc4_ipcgtw_cmd *cmd,
162162
break;
163163

164164
default:
165-
comp_err(dev, "copier_ipcgtw_process(): unexpected cmd: %u",
165+
comp_err(dev, "unexpected cmd: %u",
166166
(unsigned int)cmd->primary.r.cmd);
167167
return -EINVAL;
168168
}
@@ -180,15 +180,15 @@ int copier_ipcgtw_params(struct ipcgtw_data *ipcgtw_data, struct comp_dev *dev,
180180

181181
buf = get_buffer(dev);
182182
if (!buf) {
183-
comp_err(dev, "ipcgtw_params(): no buffer found");
183+
comp_err(dev, "no buffer found");
184184
return -EINVAL;
185185
}
186186

187187
/* resize buffer to size specified in IPC gateway config blob */
188188
err = buffer_set_size(buf, ipcgtw_data->buf_size, 0);
189189

190190
if (err < 0) {
191-
comp_err(dev, "ipcgtw_params(): failed to resize buffer to %u bytes",
191+
comp_err(dev, "failed to resize buffer to %u bytes",
192192
ipcgtw_data->buf_size);
193193
return err;
194194
}
@@ -203,7 +203,7 @@ void copier_ipcgtw_reset(struct comp_dev *dev)
203203
if (buf) {
204204
audio_stream_reset(&buf->stream);
205205
} else {
206-
comp_warn(dev, "ipcgtw_reset(): no buffer found");
206+
comp_warn(dev, "no buffer found");
207207
}
208208
}
209209

@@ -221,7 +221,7 @@ __cold int copier_ipcgtw_create(struct comp_dev *dev, struct copier_data *cd,
221221

222222
gtw_cfg = &copier->gtw_cfg;
223223
if (!gtw_cfg->config_length) {
224-
comp_err(dev, "ipcgtw_create(): empty ipc4_gateway_config_data");
224+
comp_err(dev, "empty ipc4_gateway_config_data");
225225
return -EINVAL;
226226
}
227227

@@ -244,7 +244,7 @@ __cold int copier_ipcgtw_create(struct comp_dev *dev, struct copier_data *cd,
244244
/* The buffer connected to the IPC gateway will be resized later in ipcgtw_params()
245245
* to the size specified in the IPC gateway blob.
246246
*/
247-
comp_dbg(dev, "ipcgtw_create(): buffer_size: %u", blob->buffer_size);
247+
comp_dbg(dev, "buffer_size: %u", blob->buffer_size);
248248
ipcgtw_data->buf_size = blob->buffer_size;
249249

250250
cd->converter[IPC4_COPIER_GATEWAY_PIN] =

src/audio/dcblock/dcblock.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,14 @@ static int dcblock_init(struct processing_module *mod)
9999
/* component model data handler */
100100
cd->model_handler = comp_data_blob_handler_new(dev);
101101
if (!cd->model_handler) {
102-
comp_err(dev, "dcblock_init(): comp_data_blob_handler_new() failed.");
102+
comp_err(dev, "comp_data_blob_handler_new() failed.");
103103
ret = -ENOMEM;
104104
goto err_cd;
105105
}
106106

107107
ret = comp_init_data_blob(cd->model_handler, bs, ipc_dcblock->data);
108108
if (ret < 0) {
109-
comp_err(dev, "dcblock_init(): comp_init_data_blob() failed with error: %d", ret);
109+
comp_err(dev, "comp_init_data_blob() failed with error: %d", ret);
110110
goto err_model_cd;
111111
}
112112

src/audio/selector/selector.c

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ static int selector_verify_params(struct comp_dev *dev,
6868
buffer = comp_dev_get_first_data_consumer(dev);
6969
if (cd->config.in_channels_count &&
7070
cd->config.in_channels_count != params->channels) {
71-
comp_err(dev, "selector_verify_params(): src in_channels_count does not match pcm channels");
71+
comp_err(dev, "src in_channels_count does not match pcm channels");
7272
return -EINVAL;
7373
}
7474
in_channels = cd->config.in_channels_count;
@@ -86,7 +86,7 @@ static int selector_verify_params(struct comp_dev *dev,
8686
buffer = comp_dev_get_first_data_producer(dev);
8787
if (cd->config.out_channels_count &&
8888
cd->config.out_channels_count != params->channels) {
89-
comp_err(dev, "selector_verify_params(): src in_channels_count does not match pcm channels");
89+
comp_err(dev, "src in_channels_count does not match pcm channels");
9090
return -EINVAL;
9191
}
9292
out_channels = cd->config.out_channels_count;
@@ -113,7 +113,7 @@ static int selector_verify_params(struct comp_dev *dev,
113113
case SEL_SOURCE_4CH:
114114
break;
115115
default:
116-
comp_err(dev, "selector_verify_params(): in_channels = %u", in_channels);
116+
comp_err(dev, "in_channels = %u", in_channels);
117117
return -EINVAL;
118118
}
119119

@@ -125,19 +125,19 @@ static int selector_verify_params(struct comp_dev *dev,
125125
case SEL_SINK_4CH:
126126
/* verify proper channels for passthrough mode */
127127
if (in_channels != out_channels) {
128-
comp_err(dev, "selector_verify_params(): in_channels = %u, out_channels = %u"
128+
comp_err(dev, "in_channels = %u, out_channels = %u"
129129
, in_channels, out_channels);
130130
return -EINVAL;
131131
}
132132
break;
133133
default:
134-
comp_err(dev, "selector_verify_params(): out_channels = %u"
134+
comp_err(dev, "out_channels = %u"
135135
, out_channels);
136136
return -EINVAL;
137137
}
138138

139139
if (cd->config.sel_channel > (params->channels - 1)) {
140-
comp_err(dev, "selector_verify_params(): ch_idx = %u"
140+
comp_err(dev, "ch_idx = %u"
141141
, cd->config.sel_channel);
142142
return -EINVAL;
143143
}
@@ -211,7 +211,7 @@ static int selector_params(struct comp_dev *dev,
211211

212212
err = selector_verify_params(dev, params);
213213
if (err < 0) {
214-
comp_err(dev, "selector_params(): pcm params verification failed.");
214+
comp_err(dev, "pcm params verification failed.");
215215
return -EINVAL;
216216
}
217217

@@ -244,7 +244,7 @@ static int selector_ctrl_set_data(struct comp_dev *dev,
244244
cd->config.sel_channel = cfg->sel_channel;
245245
break;
246246
default:
247-
comp_err(dev, "selector_ctrl_set_cmd(): invalid cdata->cmd = %u",
247+
comp_err(dev, "invalid cdata->cmd = %u",
248248
cdata->cmd);
249249
ret = -EINVAL;
250250
break;
@@ -284,7 +284,7 @@ static int selector_ctrl_get_data(struct comp_dev *dev,
284284
break;
285285

286286
default:
287-
comp_err(dev, "selector_ctrl_get_data(): invalid cdata->cmd");
287+
comp_err(dev, "invalid cdata->cmd");
288288
ret = -EINVAL;
289289
break;
290290
}
@@ -322,7 +322,7 @@ static int selector_cmd(struct comp_dev *dev, int cmd, void *data,
322322
comp_dbg(dev, "selector_cmd(), COMP_CMD_GET_VALUE");
323323
break;
324324
default:
325-
comp_err(dev, "selector_cmd(): invalid command");
325+
comp_err(dev, "invalid command");
326326
ret = -EINVAL;
327327
}
328328

@@ -444,38 +444,38 @@ static int selector_prepare(struct comp_dev *dev)
444444
* proper number of channels [1] for selector to actually
445445
* reduce channel count between source and sink
446446
*/
447-
comp_dbg(dev, "selector_prepare(): sourceb->schannels = %u",
447+
comp_dbg(dev, "sourceb->schannels = %u",
448448
audio_stream_get_channels(&sourceb->stream));
449-
comp_dbg(dev, "selector_prepare(): sinkb->channels = %u",
449+
comp_dbg(dev, "sinkb->channels = %u",
450450
audio_stream_get_channels(&sinkb->stream));
451451

452452
sink_size = audio_stream_get_size(&sinkb->stream);
453453

454454
if (sink_size < cd->sink_period_bytes) {
455-
comp_err(dev, "selector_prepare(): sink buffer size %zu is insufficient < %d",
455+
comp_err(dev, "sink buffer size %zu is insufficient < %d",
456456
sink_size, cd->sink_period_bytes);
457457
ret = -ENOMEM;
458458
goto err;
459459
}
460460

461461
/* validate */
462462
if (cd->sink_period_bytes == 0) {
463-
comp_err(dev, "selector_prepare(): cd->sink_period_bytes = 0, dev->frames = %u",
463+
comp_err(dev, "cd->sink_period_bytes = 0, dev->frames = %u",
464464
dev->frames);
465465
ret = -EINVAL;
466466
goto err;
467467
}
468468

469469
if (cd->source_period_bytes == 0) {
470-
comp_err(dev, "selector_prepare(): cd->source_period_bytes = 0, dev->frames = %u",
470+
comp_err(dev, "cd->source_period_bytes = 0, dev->frames = %u",
471471
dev->frames);
472472
ret = -EINVAL;
473473
goto err;
474474
}
475475

476476
cd->sel_func = sel_get_processing_function(dev);
477477
if (!cd->sel_func) {
478-
comp_err(dev, "selector_prepare(): invalid cd->sel_func, cd->source_format = %u, cd->sink_format = %u, cd->out_channels_count = %u",
478+
comp_err(dev, "invalid cd->sel_func, cd->source_format = %u, cd->sink_format = %u, cd->out_channels_count = %u",
479479
cd->source_format, cd->sink_format,
480480
cd->config.out_channels_count);
481481
ret = -EINVAL;
@@ -603,13 +603,13 @@ static int selector_init(struct processing_module *mod)
603603

604604
if (init_cfg_ext->base_cfg_ext.nb_input_pins != SEL_NUM_IN_PIN_FMTS ||
605605
init_cfg_ext->base_cfg_ext.nb_output_pins != SEL_NUM_OUT_PIN_FMTS) {
606-
comp_err(mod->dev, "selector_init(): Invalid pin configuration");
606+
comp_err(mod->dev, "Invalid pin configuration");
607607
return -EINVAL;
608608
}
609609
} else if (cfg->size == base_cfg_size + bs[1]) {
610610
payload_fmt = IPC4_SEL_INIT_PAYLOAD_BASE_WITH_OUT_FMT;
611611
} else {
612-
comp_err(mod->dev, "selector_init(): Invalid configuration size");
612+
comp_err(mod->dev, "Invalid configuration size");
613613
return -EINVAL;
614614
}
615615

@@ -696,13 +696,13 @@ static int selector_verify_params(struct processing_module *mod,
696696

697697
/* verify input channels */
698698
if (in_channels == 0 || in_channels > SEL_SOURCE_CHANNELS_MAX) {
699-
comp_err(dev, "selector_verify_params(): in_channels = %u", in_channels);
699+
comp_err(dev, "in_channels = %u", in_channels);
700700
return -EINVAL;
701701
}
702702

703703
/* verify output channels */
704704
if (out_channels == 0 || out_channels > SEL_SINK_CHANNELS_MAX) {
705-
comp_err(dev, "selector_verify_params(): out_channels = %u", out_channels);
705+
comp_err(dev, "out_channels = %u", out_channels);
706706
return -EINVAL;
707707
}
708708

@@ -756,7 +756,7 @@ static int selector_params(struct processing_module *mod)
756756

757757
err = selector_verify_params(mod, params);
758758
if (err < 0) {
759-
comp_err(mod->dev, "selector_params(): pcm params verification failed.");
759+
comp_err(mod->dev, "pcm params verification failed.");
760760
return -EINVAL;
761761
}
762762

@@ -855,7 +855,7 @@ static int selector_prepare(struct processing_module *mod,
855855
* proper number of channels [1] for selector to actually
856856
* reduce channel count between source and sink
857857
*/
858-
comp_info(dev, "selector_prepare(): source sink channel = %u %u",
858+
comp_info(dev, "source sink channel = %u %u",
859859
audio_stream_get_channels(&sourceb->stream),
860860
audio_stream_get_channels(&sinkb->stream));
861861

@@ -865,27 +865,27 @@ static int selector_prepare(struct processing_module *mod,
865865
md->mpd.out_buff_size = cd->sink_period_bytes;
866866

867867
if (sink_size < cd->sink_period_bytes) {
868-
comp_err(dev, "selector_prepare(): sink buffer size %d is insufficient < %d",
868+
comp_err(dev, "sink buffer size %d is insufficient < %d",
869869
sink_size, cd->sink_period_bytes);
870870
return -ENOMEM;
871871
}
872872

873873
/* validate */
874874
if (cd->sink_period_bytes == 0) {
875-
comp_err(dev, "selector_prepare(): cd->sink_period_bytes = 0, dev->frames = %u",
875+
comp_err(dev, "cd->sink_period_bytes = 0, dev->frames = %u",
876876
dev->frames);
877877
return -EINVAL;
878878
}
879879

880880
if (cd->source_period_bytes == 0) {
881-
comp_err(dev, "selector_prepare(): cd->source_period_bytes = 0, dev->frames = %u",
881+
comp_err(dev, "cd->source_period_bytes = 0, dev->frames = %u",
882882
dev->frames);
883883
return -EINVAL;
884884
}
885885

886886
cd->sel_func = sel_get_processing_function(mod);
887887
if (!cd->sel_func) {
888-
comp_err(dev, "selector_prepare(): invalid cd->sel_func, cd->source_format = %u, cd->sink_format = %u, cd->out_channels_count = %u",
888+
comp_err(dev, "invalid cd->sel_func, cd->source_format = %u, cd->sink_format = %u, cd->out_channels_count = %u",
889889
cd->source_format, cd->sink_format,
890890
cd->config.out_channels_count);
891891
return -EINVAL;

0 commit comments

Comments
 (0)