library-manager: fix a potential NULL dereference

If module registration fails, lib_manager_load_library() will jump to
"cleanup" where it will attempt to check whether a module is an LLEXT
but in such cases the "mod" pointer can be NULL, which will cause an
exception. Check the error code before checking the module type.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>

Author: lyakh

src/library_manager/lib_manager.c

@@ -1030,7 +1030,7 @@ int lib_manager_load_library(uint32_t dma_id, uint32_t lib_id, uint32_t type)
 	uint32_t module_id = lib_id << LIB_MANAGER_LIB_ID_SHIFT;
 	const struct sof_man_module *mod = lib_manager_get_module_manifest(module_id);
 
-	if (module_is_llext(mod) && !ret)
+	if (!ret && module_is_llext(mod))
 		/* Auxiliary LLEXT libraries need to be linked upon loading */
 		ret = llext_manager_add_library(module_id);
 
@@ -1039,7 +1039,7 @@ int lib_manager_load_library(uint32_t dma_id, uint32_t lib_id, uint32_t type)
 #endif
 
 	if (!ret)
-		tr_info(&ipc_tr, "loaded library id: %u", lib_id);
+		tr_info(&lib_manager_tr, "loaded library id: %u", lib_id);
 
 	return ret;
 }