Skip to content

Commit e79442a

Browse files
committed
module: cadence_ipc4: Fix dereferencing of uninitialized pointer
setup_cfg can be in theory undefined when no module_data is provided, initialize it to NULL and check for NULL pointer before accessing to it's member. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
1 parent 7966ba4 commit e79442a

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/audio/module_adapter/module/cadence_ipc4.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,8 @@ static int cadence_codec_init(struct processing_module *mod)
217217
struct module_data *codec = &mod->priv;
218218
struct module_config *cfg = &codec->cfg;
219219
struct module_ext_init_data *ext_data = cfg->ext_data;
220+
struct module_config *setup_cfg = NULL;
220221
struct cadence_codec_data *cd;
221-
struct module_config *setup_cfg;
222222
struct comp_dev *dev = mod->dev;
223223
int mem_tabs_size;
224224
int ret;
@@ -308,7 +308,8 @@ static int cadence_codec_init(struct processing_module *mod)
308308
free:
309309
mod_free(mod, cd->mem_tabs);
310310
free_cfg:
311-
mod_free(mod, setup_cfg->data);
311+
if (setup_cfg)
312+
mod_free(mod, setup_cfg->data);
312313
free_cd:
313314
mod_free(mod, cd);
314315

0 commit comments

Comments
 (0)