module_adapter: Allocate data buffers from MMU shared heap

Allocates audio data buffer from shared memory heap.

The security reqirements assume that the non-privileged
modules data and code should be protected from other non-privileged
modules access. The audio data could be accessible.

This change is effective only when CONFIG_USERSPACE=y.

Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

Author: jxstelter

src/audio/module_adapter/module_adapter.c

@@ -210,6 +210,7 @@ int module_adapter_prepare(struct comp_dev *dev)
 	struct list_item *blist, *_blist;
 	uint32_t buff_periods;
 	uint32_t buff_size; /* size of local buffer */
+	int memory_flags;
 	int i = 0;
 
 	comp_dbg(dev, "module_adapter_prepare() start");
@@ -342,11 +343,11 @@ int module_adapter_prepare(struct comp_dev *dev)
 
 	module_adapter_check_data(mod, dev, sink);
 
+	memory_flags = user_get_buffer_memory_region(dev->drv);
 	/* allocate memory for input buffers */
 	if (mod->max_sources) {
 		mod->input_buffers =
-			rzalloc(SOF_MEM_FLAG_USER,
-				sizeof(*mod->input_buffers) * mod->max_sources);
+			rzalloc(memory_flags, sizeof(*mod->input_buffers) * mod->max_sources);
 		if (!mod->input_buffers) {
 			comp_err(dev, "failed to allocate input buffers");
 			return -ENOMEM;
@@ -358,8 +359,7 @@ int module_adapter_prepare(struct comp_dev *dev)
 	/* allocate memory for output buffers */
 	if (mod->max_sinks) {
 		mod->output_buffers =
-			rzalloc(SOF_MEM_FLAG_USER,
-				sizeof(*mod->output_buffers) * mod->max_sinks);
+			rzalloc(memory_flags, sizeof(*mod->output_buffers) * mod->max_sinks);
 		if (!mod->output_buffers) {
 			comp_err(dev, "failed to allocate output buffers");
 			ret = -ENOMEM;
@@ -425,7 +425,7 @@ int module_adapter_prepare(struct comp_dev *dev)
 	list_for_item(blist, &dev->bsource_list) {
 		size_t size = MAX(mod->deep_buff_bytes, mod->period_bytes);
 
-		mod->input_buffers[i].data = rballoc(SOF_MEM_FLAG_USER, size);
+		mod->input_buffers[i].data = rballoc(memory_flags, size);
 		if (!mod->input_buffers[i].data) {
 			comp_err(mod->dev, "Failed to alloc input buffer data");
 			ret = -ENOMEM;
@@ -437,7 +437,7 @@ int module_adapter_prepare(struct comp_dev *dev)
 	/* allocate memory for output buffer data */
 	i = 0;
 	list_for_item(blist, &dev->bsink_list) {
-		mod->output_buffers[i].data = rballoc(SOF_MEM_FLAG_USER, md->mpd.out_buff_size);
+		mod->output_buffers[i].data = rballoc(memory_flags, md->mpd.out_buff_size);
 		if (!mod->output_buffers[i].data) {
 			comp_err(mod->dev, "Failed to alloc output buffer data");
 			ret = -ENOMEM;
@@ -450,7 +450,7 @@ int module_adapter_prepare(struct comp_dev *dev)
 	if (list_is_empty(&mod->raw_data_buffers_list)) {
 		for (i = 0; i < mod->num_of_sinks; i++) {
 			/* allocate not shared buffer */
-			struct comp_buffer *buffer = buffer_alloc(buff_size, SOF_MEM_FLAG_USER,
+			struct comp_buffer *buffer = buffer_alloc(buff_size, memory_flags,
 								  PLATFORM_DCACHE_ALIGN, false);
 			uint32_t flags;
 

src/include/sof/audio/component.h

@@ -1194,4 +1194,12 @@ void comp_init_performance_data(struct comp_dev *dev);
  */
 bool comp_update_performance_data(struct comp_dev *dev, uint32_t cycles_used);
 
+static inline int user_get_buffer_memory_region(const struct comp_driver* drv)
+{
+#if CONFIG_USERSPACE
+	return drv->user_heap ? SOF_MEM_FLAG_USER_SHARED_BUFFER : SOF_MEM_FLAG_USER;
+#else
+	return SOF_MEM_FLAG_USER;
+#endif
+}
 #endif /* __SOF_AUDIO_COMPONENT_H__ */