Skip to content
This repository was archived by the owner on Jan 17, 2019. It is now read-only.

Commit 53f90d9

Browse files
committed
Topology: DMIC: Reduce PCM capabilities to DMIC configuration
This patch impacts topologies sof-apl-nocodec, sof-apl-da7219, and sof-glk-da7219 those use the pipe-passthrough-capture macro for DMIC. The PCM saple rate is limited to 48 kHz (was 8 - 192 kHz). The capture channels count can be only PIPELINE_CHANNELS (was 1 - PIPELINE_CHANNELS). This prevents corrupted audio capture that happens when DMIC topology parameters and capture parameters differ. It happens because DMIC FIFOs drop samples or add unwanted samples when the configuration does not match. In sof-apl-nocodec topology the PIPELINE_CHANNELS is set to 2 that matches the configuration. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
1 parent 5b51dc0 commit 53f90d9

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

topology/sof-apl-nocodec.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,10 @@ PIPELINE_PCM_ADD(sof/pipe-volume-capture.m4,
112112
12, 5, 2, s16le,
113113
48, 1000, 0, 0)
114114

115-
# Passthrough capture pipeline 13 on PCM 6 using max 4 channels.
115+
# Passthrough capture pipeline 13 on PCM 6 using max 2 channels.
116116
# Schedule 48 frames per 1000us deadline on core 0 with priority 0
117117
PIPELINE_PCM_ADD(sof/pipe-passthrough-capture.m4,
118-
13, 6, 4, s32le,
118+
13, 6, 2, s32le,
119119
48, 1000, 0, 0)
120120

121121
#

topology/sof/pipe-passthrough-capture.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ indir(`define', concat(`PIPELINE_PCM_', PIPELINE_ID), Passthrough Capture PCM_ID
4444
# PCM Configuration
4545
#
4646

47-
PCM_CAPABILITIES(Passthrough Capture PCM_ID, COMP_FORMAT_NAME(PIPELINE_FORMAT), 8000, 192000, 1, PIPELINE_CHANNELS, 2, 16, 192, 16384, 65536, 65536)
47+
PCM_CAPABILITIES(Passthrough Capture PCM_ID, COMP_FORMAT_NAME(PIPELINE_FORMAT), 48000, 48000, PIPELINE_CHANNELS, PIPELINE_CHANNELS, 2, 16, 192, 16384, 65536, 65536)

0 commit comments

Comments
 (0)