Skip to content

Commit 946efa8

Browse files
committed
fix: keep versions-up aligned with core rust builds
1 parent 03e9aa2 commit 946efa8

3 files changed

Lines changed: 56 additions & 5 deletions

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ buildx-multi-local:
174174
versions-up:
175175
@MAIN_IMAGE=$(DETECTED_IMAGE) \
176176
BUILD_IMAGE=$(MAIN_IMAGE) \
177+
CORE_IMAGE=$(CORE_IMAGE) \
177178
RUST_IMAGE=$(RUST_IMAGE) \
178179
DOCKERFILE=$(DOCKERFILE) \
179180
RUST_DOCKERFILE=$(RUST_DOCKERFILE) \

scripts/version-upgrade.sh

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@ source "$SCRIPT_DIR/release-utils.sh"
1010
# Defaults
1111
CHECK_IMAGE=${MAIN_IMAGE:-ghcr.io/thevibeworks/deva:latest}
1212
BUILD_IMAGE=${BUILD_IMAGE:-ghcr.io/thevibeworks/deva:latest}
13+
CORE_IMAGE=${CORE_IMAGE:-ghcr.io/thevibeworks/deva:core}
1314
RUST_IMAGE=${RUST_IMAGE:-ghcr.io/thevibeworks/deva:rust}
1415
DOCKERFILE=${DOCKERFILE:-Dockerfile}
1516
RUST_DOCKERFILE=${RUST_DOCKERFILE:-Dockerfile.rust}
17+
GO_VERSION=${GO_VERSION:-1.26.2}
18+
PLAYWRIGHT_VERSION=${PLAYWRIGHT_VERSION:-1.59.1}
19+
PLAYWRIGHT_MCP_VERSION=${PLAYWRIGHT_MCP_VERSION:-0.0.70}
1620
COUNTDOWN=${COUNTDOWN:-5}
1721
AUTO_YES=${AUTO_YES:-}
1822

@@ -26,12 +30,16 @@ Options:
2630
2731
Environment:
2832
MAIN_IMAGE Main image name (default: ghcr.io/thevibeworks/deva:latest)
33+
CORE_IMAGE Core image name (default: ghcr.io/thevibeworks/deva:core)
2934
RUST_IMAGE Rust image name (default: ghcr.io/thevibeworks/deva:rust)
3035
CLAUDE_CODE_VERSION Override claude-code version
3136
CODEX_VERSION Override codex version
3237
GEMINI_CLI_VERSION Override gemini-cli version
3338
ATLAS_CLI_VERSION Override atlas-cli version
3439
COPILOT_API_VERSION Override copilot-api version
40+
GO_VERSION Override Go version for base/core builds
41+
PLAYWRIGHT_VERSION Override Playwright version for rust builds
42+
PLAYWRIGHT_MCP_VERSION Override Playwright MCP version for rust builds
3543
EOF
3644
}
3745

@@ -48,7 +56,7 @@ main() {
4856
echo -e "${CYAN}${BOLD}║ Upgrading to Latest Versions ║${RESET}"
4957
echo -e "${CYAN}${BOLD}╚════════════════════════════════════════════════════╝${RESET}"
5058
echo -e "${DIM}Time: $(date '+%Y-%m-%d %H:%M:%S')${RESET}"
51-
echo -e "${DIM}Check: ${CHECK_IMAGE} Build: ${BUILD_IMAGE}${RESET}"
59+
echo -e "${DIM}Check: ${CHECK_IMAGE} Build: ${BUILD_IMAGE} Core: ${CORE_IMAGE}${RESET}"
5260
echo ""
5361

5462
load_versions "$CHECK_IMAGE"
@@ -94,23 +102,34 @@ main() {
94102
echo ""
95103
fi
96104

105+
section "Building Core Image"
106+
docker build -f "$DOCKERFILE" \
107+
--target agent-base \
108+
--build-arg COPILOT_API_VERSION="$copilot_ver" \
109+
--build-arg GO_VERSION="$GO_VERSION" \
110+
-t "$CORE_IMAGE" .
111+
112+
echo ""
97113
section "Building Main Image"
98114
docker build -f "$DOCKERFILE" \
99115
--build-arg CLAUDE_CODE_VERSION="$claude_ver" \
100116
--build-arg CODEX_VERSION="$codex_ver" \
101117
--build-arg GEMINI_CLI_VERSION="$gemini_ver" \
102118
--build-arg ATLAS_CLI_VERSION="$atlas_ver" \
103119
--build-arg COPILOT_API_VERSION="$copilot_ver" \
120+
--build-arg GO_VERSION="$GO_VERSION" \
104121
-t "$BUILD_IMAGE" .
105122

106123
echo ""
107124
section "Building Rust Image"
108125
docker build -f "$RUST_DOCKERFILE" \
109-
--build-arg BASE_IMAGE="$BUILD_IMAGE" \
126+
--build-arg BASE_IMAGE="$CORE_IMAGE" \
110127
--build-arg CLAUDE_CODE_VERSION="$claude_ver" \
111128
--build-arg CODEX_VERSION="$codex_ver" \
112129
--build-arg GEMINI_CLI_VERSION="$gemini_ver" \
113130
--build-arg ATLAS_CLI_VERSION="$atlas_ver" \
131+
--build-arg PLAYWRIGHT_VERSION="$PLAYWRIGHT_VERSION" \
132+
--build-arg PLAYWRIGHT_MCP_VERSION="$PLAYWRIGHT_MCP_VERSION" \
114133
-t "$RUST_IMAGE" .
115134

116135
echo ""

tests/version-upgrade.sh

Lines changed: 34 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,25 +120,56 @@ DOCKER_BUILD_LOG="$DOCKER_BUILD_LOG" \
120120
AUTO_YES=1 \
121121
CHECK_IMAGE="ghcr.io/thevibeworks/deva:rust" \
122122
BUILD_IMAGE="ghcr.io/thevibeworks/deva:latest" \
123+
CORE_IMAGE="ghcr.io/thevibeworks/deva:core" \
123124
RUST_IMAGE="ghcr.io/thevibeworks/deva:rust" \
125+
GO_VERSION="1.26.2" \
126+
PLAYWRIGHT_VERSION="1.59.1" \
127+
PLAYWRIGHT_MCP_VERSION="0.0.70" \
124128
"$REPO_ROOT/scripts/version-upgrade.sh" >/dev/null
125129

126-
main_build="$(sed -n '1p' "$DOCKER_BUILD_LOG")"
127-
rust_build="$(sed -n '2p' "$DOCKER_BUILD_LOG")"
130+
core_build="$(sed -n '1p' "$DOCKER_BUILD_LOG")"
131+
main_build="$(sed -n '2p' "$DOCKER_BUILD_LOG")"
132+
rust_build="$(sed -n '3p' "$DOCKER_BUILD_LOG")"
128133

134+
[[ -n "$core_build" ]] || { echo "missing core build invocation" >&2; exit 1; }
129135
[[ -n "$main_build" ]] || { echo "missing main build invocation" >&2; exit 1; }
130136
[[ -n "$rust_build" ]] || { echo "missing rust build invocation" >&2; exit 1; }
131137

138+
for expected in \
139+
"--target agent-base" \
140+
"--build-arg COPILOT_API_VERSION=0ea08febdd7e3e055b03dd298bf57e669500b5c1" \
141+
"--build-arg GO_VERSION=1.26.2" \
142+
"-t ghcr.io/thevibeworks/deva:core ."
143+
do
144+
[[ "$core_build" == *"$expected"* ]] || {
145+
echo "core build missing expected arg: $expected" >&2
146+
exit 1
147+
}
148+
done
149+
132150
for expected in \
133151
"--build-arg CLAUDE_CODE_VERSION=2.1.87" \
134152
"--build-arg CODEX_VERSION=0.117.0" \
135153
"--build-arg GEMINI_CLI_VERSION=0.35.3" \
136-
"--build-arg ATLAS_CLI_VERSION=v0.1.4"
154+
"--build-arg ATLAS_CLI_VERSION=v0.1.4" \
155+
"--build-arg COPILOT_API_VERSION=0ea08febdd7e3e055b03dd298bf57e669500b5c1" \
156+
"--build-arg GO_VERSION=1.26.2"
137157
do
138158
[[ "$main_build" == *"$expected"* ]] || {
139159
echo "main build missing expected arg: $expected" >&2
140160
exit 1
141161
}
162+
done
163+
164+
for expected in \
165+
"--build-arg BASE_IMAGE=ghcr.io/thevibeworks/deva:core" \
166+
"--build-arg CLAUDE_CODE_VERSION=2.1.87" \
167+
"--build-arg CODEX_VERSION=0.117.0" \
168+
"--build-arg GEMINI_CLI_VERSION=0.35.3" \
169+
"--build-arg ATLAS_CLI_VERSION=v0.1.4" \
170+
"--build-arg PLAYWRIGHT_VERSION=1.59.1" \
171+
"--build-arg PLAYWRIGHT_MCP_VERSION=0.0.70"
172+
do
142173
[[ "$rust_build" == *"$expected"* ]] || {
143174
echo "rust build missing expected arg: $expected" >&2
144175
exit 1

0 commit comments

Comments
 (0)