fix(auth): --profile matches against directory path, not just display name

User reported `--profile "Profile 6"` failing because kooky returns
the human display name (e.g. "Tammie") as `Browser.Profile()`, not
the directory ("Profile 6"). The on-disk directory only appears in
the cookie file path. Users see "Profile 6" in the path output and
expect to be able to pass it as --profile, so make that work.

internal/browsercookies.profileMatches:
  Substring-match the user's `--profile` argument against EITHER
  the human profile name (e.g. "Tammie", "Default") OR the cookie
  file path (e.g. ".../Chrome/Profile 6/Cookies"). Case-insensitive
  on both. The kooky-traversal call now goes through this helper.

Both forms now work:

  x auth import --profile Tammie
  x auth import --profile tammie
  x auth import --profile "Profile 6"
  x auth import --profile "profile 6"

Plus a TestProfileMatches with eight cases pinning the rule (display
name match, substring match, path match, and three negative cases).

Author: lroolle

internal/browsercookies/browsercookies.go

@@ -102,13 +102,14 @@ func Load(ctx context.Context, browser, profile, domain string) (*Result, error)
 		}
 		actualBrowser := c.Browser.Browser()
 		actualProfile := c.Browser.Profile()
+		actualPath := c.Browser.FilePath()
 		if browser != "" && !strings.EqualFold(actualBrowser, browser) {
 			continue
 		}
-		if profile != "" && !strings.Contains(strings.ToLower(actualProfile), strings.ToLower(profile)) {
+		if profile != "" && !profileMatches(profile, actualProfile, actualPath) {
 			continue
 		}
-		key := storeKey{browser: actualBrowser, profile: actualProfile, source: c.Browser.FilePath()}
+		key := storeKey{browser: actualBrowser, profile: actualProfile, source: actualPath}
 		b, ok := stores[key]
 		if !ok {
 			b = &bucket{key: key, cookies: map[string]string{}}
@@ -196,6 +197,22 @@ func List(ctx context.Context, domain string) ([]Match, error) {
 	return out, nil
 }
 
+// profileMatches returns true when `want` (the user-supplied --profile
+// substring) matches either the human profile name from kooky (e.g.
+// "Tammie", "Default", "Work") OR a path component of the cookie file
+// (e.g. "Profile 6" from ".../Chrome/Profile 6/Cookies"). Case-
+// insensitive substring on both. This keeps `--profile "Profile 6"`
+// working alongside `--profile tammie`.
+func profileMatches(want, name, path string) bool {
+	w := strings.ToLower(want)
+	if strings.Contains(strings.ToLower(name), w) {
+		return true
+	}
+	// Match against the directory path so users can pass the on-disk
+	// "Profile N" name they see in `x auth browsers`.
+	return strings.Contains(strings.ToLower(path), w)
+}
+
 // FormatCookieHeader joins the relevant subset of a cookie map into a
 // `name=value; name=value` string suitable for `Cookie:` headers and
 // for x-cli's auth-import parser. Only names in `wanted` are kept; pass

internal/browsercookies/browsercookies_test.go

@@ -83,3 +83,32 @@ func TestListEmptyDomain(t *testing.T) {
 		t.Error("expected error for empty domain")
 	}
 }
+
+func TestProfileMatches(t *testing.T) {
+	cases := []struct {
+		want   string
+		name   string
+		path   string
+		expect bool
+	}{
+		// Match by human profile name (kooky's Browser.Profile()).
+		{"tammie", "Tammie", "/x/Chrome/Profile 6/Cookies", true},
+		{"Tammie", "Tammie", "/x/Chrome/Profile 6/Cookies", true},
+		{"tam", "Tammie", "/x/Chrome/Profile 6/Cookies", true},
+		// Match by on-disk directory name (what users see in errors).
+		{"Profile 6", "Tammie", "/x/Chrome/Profile 6/Cookies", true},
+		{"profile 6", "Tammie", "/x/Chrome/Profile 6/Cookies", true},
+		// Default profile.
+		{"default", "Default", "/x/Chrome/Default/Cookies", true},
+		// Misses.
+		{"profile 7", "Tammie", "/x/Chrome/Profile 6/Cookies", false},
+		{"work", "Tammie", "/x/Chrome/Profile 6/Cookies", false},
+	}
+	for _, tc := range cases {
+		got := profileMatches(tc.want, tc.name, tc.path)
+		if got != tc.expect {
+			t.Errorf("profileMatches(%q, %q, %q) = %v, want %v",
+				tc.want, tc.name, tc.path, got, tc.expect)
+		}
+	}
+}