Some cleanup and typos fixed.

Author: raidoz

cmd/deviceparameter/deviceparameter.go

@@ -149,8 +149,8 @@ type Options struct {
 	Int32  string `long:"i32" description:"Set value, type is int32"`
 	Int64  string `long:"i64" description:"Set value, type is int64"`
 
-	Debug       []bool `short:"D" long:"debug"   description:"Debug mode, print raw packets"`
 	Quiet       []bool `short:"Q" long:"quiet"   description:"Quiet mode, print only values"`
+	Debug       []bool `short:"D" long:"debug"   description:"Debug mode, print raw packets"`
 	ShowVersion func() `short:"V" long:"version" description:"Show application version"`
 }
 

cmd/deviceparameters/README.md

@@ -68,7 +68,7 @@ and it will be updated according to the information received from the node.
 
   * `raw`:
     Values of the raw type are treated as hex strings and converted to binary.
-    The value must have a length that is devisible by 2 and only contain symbols
+    The value must have a length that is divisible by 2 and only contain symbols
     [0-9abcdef]. Value is not case sensitive.
   * `str`:
     String values are converted to binary using the ASCII encoding. For transmitting
@@ -82,13 +82,13 @@ and it will be updated according to the information received from the node.
   * `u64`:
     The value is converted to an unsigned 64-bit big-endian integer.
   * `i8`:
-    The value is converted to an signed 8-bit big-endian integer.
+    The value is converted to a signed 8-bit big-endian integer.
   * `i16`:
-    The value is converted to an signed 16-bit big-endian integer.
+    The value is converted to a signed 16-bit big-endian integer.
   * `i32`:
-    The value is converted to an signed 32-bit big-endian integer.
+    The value is converted to a signed 32-bit big-endian integer.
   * `i64`:
-    The value is converted to an signed 64-bit big-endian integer.
+    The value is converted to a signed 64-bit big-endian integer.
   * `nil`:
     The nil type can be used to set the length of variable length parameters
     (`raw` and `str`) to 0.
@@ -125,11 +125,11 @@ Options control connection parameters:
 
   * `-g`, `--group`:
   option is used to set the ActiveMessage group. The default is 22,
-the value is trated as a hex string (0x22).
+the value is parsed as a hex string (0x22).
 
   * `-a`, `--address`:
   option is used to set the source ActiveMessage address.
-  The default is 5678, the value is treated as a hex string (0x5678).
+  The default is 5678, the value is parsed as a hex string (0x5678).
 
 Options for controlling task processing timings:
 

cmd/deviceparameters/deviceparameters.go

@@ -9,12 +9,6 @@ import "log"
 import "time"
 import "os/signal"
 
-//import "errors"
-//import "encoding/hex"
-//import "encoding/binary"
-//import "strconv"
-//import "bytes"
-
 import "github.com/jessevdk/go-flags"
 import "github.com/proactivity-lab/go-loggers"
 import "github.com/proactivity-lab/go-moteconnection"
@@ -44,7 +38,6 @@ type Options struct {
 	Retries uint8 `long:"retries" default:"3" description:"Get/set action retries"`
 
 	Debug       []bool `short:"D" long:"debug"   description:"Debug mode, print raw packets"`
-	Quiet       []bool `short:"Q" long:"quiet"   description:"Quiet mode, print only values"`
 	ShowVersion func() `short:"V" long:"version" description:"Show application version"`
 }
 
@@ -93,12 +86,10 @@ func main() {
 
 	time.Sleep(5 * time.Second)
 
-	if len(opts.Quiet) == 0 {
-		if conn.Connected() {
-			logger.Info.Printf("Connected with %s\n", cs)
-		} else {
-			logger.Info.Printf("Not (yet?) connected with %s\n", cs)
-		}
+	if conn.Connected() {
+		logger.Info.Printf("Connected with %s\n", cs)
+	} else {
+		logger.Info.Printf("Not (yet?) connected with %s\n", cs)
 	}
 
 	success := false
@@ -135,9 +126,7 @@ func main() {
 	time.Sleep(100 * time.Millisecond)
 
 	if success {
-		if len(opts.Quiet) == 0 {
-			logger.Info.Printf("Done")
-		}
+		logger.Info.Printf("Done")
 		os.Exit(0)
 	} else {
 		os.Exit(1)