Merge pull request #47 from lepidus/stable-3_3_0

fix/use chapter pages field for page interval instead page count (OMP 3.3.0)

Author: thiagolepidus

classes/factories/ThothChapterFactory.inc.php

@@ -28,6 +28,8 @@ public function createFromChapter($chapter)
         $submission = DAORegistry::getDAO('SubmissionDAO')->getById($publication->getData('submissionId'));
         $context = Application::getContextDAO()->getById($submission->getData('contextId'));
 
+        $pages = $this->extractPages($chapter);
+
         return new ThothWork([
             'workType' => ThothWork::WORK_TYPE_BOOK_CHAPTER,
             'workStatus' => $this->getWorkStatusByDatePublished($chapter, $publication),
@@ -36,7 +38,9 @@ public function createFromChapter($chapter)
             'subtitle' => $chapter->getLocalizedData('subtitle'),
             'longAbstract' => HtmlStripper::stripTags($chapter->getLocalizedData('abstract')),
             'doi' => DoiFormatter::resolveUrl($chapter->getStoredPubId('doi')),
-            'pageCount' => $chapter->getPages(),
+            'pageInterval' => $pages['pageInterval'] ?? null,
+            'firstPage' => $pages['firstPage'] ?? null,
+            'lastPage' => $pages['lastPage'] ?? null,
             'publicationDate' => $chapter->getDatePublished() ?? $publication->getData('datePublished'),
             'landingPage' => $request->getDispatcher()->url(
                 $request,
@@ -49,6 +53,28 @@ public function createFromChapter($chapter)
         ]);
     }
 
+    private function extractPages($chapter): array
+    {
+        $pages = $chapter->getPages();
+
+        if (empty($pages)) {
+            return [];
+        }
+
+        if (strpos($pages, '-') === false) {
+            return [
+                'firstPage' => trim($pages),
+            ];
+        }
+
+        list($firstPage, $lastPage) = explode('-', $pages);
+        return [
+            'pageInterval' => trim($pages),
+            'firstPage' => trim($firstPage),
+            'lastPage' => trim($lastPage)
+        ];
+    }
+
     public function getWorkStatusByDatePublished($chapter, $publication)
     {
         $dataPublished = $chapter->getDatePublished() ?? $publication->getData('datePublished');

tests/classes/factories/ThothChapterFactoryTest.php

@@ -136,7 +136,7 @@ private function setUpMockEnvironment()
             ->will($this->returnValue('10.12345/11112222'));
         $mockChapter->expects($this->any())
             ->method('getPages')
-            ->will($this->returnValue('31'));
+            ->will($this->returnValue('31 - 50'));
         $mockChapter->expects($this->any())
             ->method('getDatePublished')
             ->will($this->returnValue('2024-01-01'));
@@ -162,7 +162,9 @@ public function testCreateThothChapterFromChapter()
             'longAbstract' => 'This is my chapter abstract',
             'publicationDate' => '2024-01-01',
             'doi' => 'https://doi.org/10.12345/11112222',
-            'pageCount' => 31,
+            'pageInterval' => '31 - 50',
+            'firstPage' => '31',
+            'lastPage' => '50',
             'landingPage' => 'https://omp.publicknowledgeproject.org/index.php/press/catalog/book/17'
         ]), $thothChapter);
     }

version.xml

@@ -3,8 +3,8 @@
 <version>
 	<application>thoth</application>
 	<type>plugins.generic</type>
-	<release>0.1.10.4</release>
-	<date>2025-08-11</date>
+	<release>0.1.10.5</release>
+	<date>2025-08-15</date>
 	<lazy-load>1</lazy-load>
 	<class>ThothPlugin</class>
 </version>