Skip to content

Commit 273fd84

Browse files
committed
* Minor adjustments
1 parent b8fadc4 commit 273fd84

5 files changed

Lines changed: 10 additions & 26 deletions

File tree

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ dist/*
66
node_modules/
77
.idea/
88
.vscode/
9+
package-lock.json
10+
yarn.lock
911

1012
######################
1113
# OS Generated Files #

README.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ The PHP logotype is property of [The PHP Group](https://www.php.net/credits.php)
2525

2626
The javascript source code editor bundled with this software is [CodeMirror](https://codemirror.net/).
2727

28-
# How To Build
29-
30-
3128
## How To Build
3229

3330
Make sure you have Node.js v22+ installed and follow these steps to build PHP Fiddle from source:
@@ -36,15 +33,12 @@ Make sure you have Node.js v22+ installed and follow these steps to build PHP Fi
3633
# Clone the project and navigate to the directory
3734
git clone https://github.com/timint/phpfiddle.git && cd phpfiddle
3835

39-
# Install yarn package manager
40-
npm install --g yarn
41-
4236
# Install dependencies
43-
yarn install
37+
npm install
4438

4539
# Simulate running the app
46-
yarn run start
40+
npm run start
4741

4842
# Build and compile app to dist/ folder
49-
yarn run build
43+
npm run build
5044
```

app/main.mjs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ let mainWindow;
2222
function createWindow() {
2323
let runtimePromise = phpRuntime.run();
2424

25-
mainWindow = new BrowserWindow({width: config.window.width, height: config.window.height});
25+
mainWindow = new BrowserWindow({
26+
width: config.window.width,
27+
height: config.window.height
28+
});
2629
mainWindow.loadURL('http://'+phpRuntime.host+':'+phpRuntime.port+'/');
2730

2831
//mainWindow.webContents.openDevTools()

app/server.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ function checkServer(host, port, cb) {
102102
.on('error', err => {
103103
if (err.code === 'ECONNREFUSED') {
104104
console.error('PHP server not started. Retrying...');
105-
setTimeout(runCheck, 250);
105+
setTimeout(runCheck, 1000);
106106
} else {
107107
cb();
108108
}

package.json

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,5 @@
3131
"scripts": {
3232
"start": "electron .",
3333
"build": "node build.mjs"
34-
},
35-
"build": {
36-
"directories": {
37-
"buildResources": "build"
38-
},
39-
"win": {
40-
"asar": false,
41-
"target": "nsis",
42-
"icon": "icons/icon.ico"
43-
},
44-
"nsis": {
45-
"installerIcon": "icons/icon.ico",
46-
"installerHeaderIcon": "icons/icon.ico",
47-
"deleteAppDataOnUninstall": true
48-
}
4934
}
5035
}

0 commit comments

Comments
 (0)