fix pylint warnings

Author: timotheus

ebaysdk/connection.py

@@ -43,6 +43,7 @@ def __init__(self, debug=False, method='GET',
         self.response = None
         self.request = None
         self.verb = None
+        self.config = None
         self.debug = debug
         self.method = method
         self.timeout = timeout
@@ -146,7 +147,7 @@ def build_request(self, verb, data, verb_attrs, files=None):
         requestData = self.build_request_data(verb, data, verb_attrs)
         if files:
             del(headers['Content-Type'])
-            if isinstance(requestData, basestring):
+            if isinstance(requestData, basestring): # pylint: disable-msg=E0602
                 requestData = {'XMLPayload':requestData}
 
         request = Request(self.method,
@@ -158,6 +159,12 @@ def build_request(self, verb, data, verb_attrs, files=None):
 
         self.request = request.prepare()
 
+    def build_request_headers(self, verb):
+        return {}
+
+    def build_request_data(self, verb, data, verb_attrs):
+        return ""
+
     def build_request_url(self, verb):
         url = "%s://%s%s" % (
             HTTP_SSL[self.config.get('https', False)],

ebaysdk/response.py

@@ -9,6 +9,7 @@
 import lxml
 import copy
 import datetime
+from lxml.etree import XMLSyntaxError # pylint: disable-msg=E0611
 
 from collections import defaultdict
 import json
@@ -55,7 +56,7 @@ def _load_dict(self, mydict, datetime_nodes):
         if sys.version_info[0] >= 3:
             datatype = bytes
         else:
-            datatype = unicode
+            datatype = unicode # pylint: disable-msg=E0602
 
         for a in mydict.items():
 
@@ -113,7 +114,7 @@ class Response(object):
     >>> len(r.dom().getchildren()) > 2
     True
     >>> import json
-    >>> j = json.loads(r.json(), 'utf8')
+    >>> j = json.loads(r.json(), encoding='utf8')
     >>> json.dumps(j, sort_keys=True)
     '{"ack": "Success", "itemSearchURL": "http://www.ebay.com/ctg/53039031?_ddo=1&_ipg=2&_pgn=1", "paginationOutput": {"entriesPerPage": "2", "pageNumber": "1", "totalEntries": "179", "totalPages": "90"}, "searchResult": {"_count": "2", "item": [{"name": "Item Two", "shipping": {"c": ["US", "MX"]}}, {"name": "Item One"}]}, "timestamp": "2014-02-07T23:31:13.941Z", "version": "1.12.0"}'
     >>> sorted(r.dict().keys())
@@ -153,7 +154,7 @@ def __init__(self, obj, verb=None, list_nodes=[], datetime_nodes=[], parse_respo
 
                 self.reply = ResponseDataObject(self._dict,
                                                 datetime_nodes=copy.copy(datetime_nodes))
-            except lxml.etree.XMLSyntaxError as e:
+            except XMLSyntaxError as e:
                 log.debug('response parse failed: %s' % e)
                 self.reply = ResponseDataObject({}, [])
         else:
@@ -180,7 +181,7 @@ def _pullval(v):
             return v
 
     def _etree_to_dict(self, t):
-        if type(t) == lxml.etree._Comment:
+        if type(t) == lxml.etree._Comment: # pylint: disable=no-member
             return {}
 
         # remove xmlns from nodes, I find them meaningless

ebaysdk/utils.py

@@ -10,6 +10,9 @@
 from lxml import etree as ET
 from xml.sax.saxutils import escape
 
+if sys.version_info[0] >= 3:
+    unicode = str
+    long = int
 
 def parse_yaml(yaml_file):
     """
@@ -70,7 +73,7 @@ def python_2_unicode_compatible(klass):
 
 
 def get_dom_tree(xml):
-    tree = ET.fromstring(xml)
+    tree = ET.fromstring(xml) # pylint: disable=no-member
     return tree.getroottree().getroot()
 
 
@@ -100,7 +103,7 @@ def smart_encode_request_data(value):
 def smart_encode(value):
     try:
         if sys.version_info[0] < 3:
-            return unicode(value).encode('utf-8')
+            return unicode(value).encode('utf-8') # pylint: disable-msg=E0602
         else:
             return value
             #return str(value)
@@ -263,8 +266,8 @@ def dict2xml(root, escape_xml=False):
                     .format(**{'xml': str(xml), 'tag': key, 'value': smart_encode(value)})
 
     elif isinstance(root, str) or isinstance(root, int) \
-        or isinstance(root, unicode) or isinstance(root, long) \
-        or isinstance(root, float):
+        or isinstance(root, float) or isinstance(root, long) \
+        or isinstance(root, unicode): 
         xml = str('{0}{1}').format(str(xml), smart_encode(root))
     else:
         raise Exception('Unable to serialize node of type %s (%s)' % \

tests/test_perf.py samples/test_perf.pytests/test_perf.py renamed to samples/test_perf.py

@@ -31,6 +31,13 @@
 calls, response processing, error handling, debugging across the Finding,
 Shopping, Merchandising, & Trading APIs. """
 
+def requirements_file_to_list(fn="requirements.txt"):
+    """read a requirements file and create a list that can be used in setup.
+    """
+
+    with open(fn, 'r') as f:
+        return [x.rstrip() for x in list(f) if x and not x.startswith('#')]
+
 setup(
     name=PKG,
     version=version,
@@ -41,7 +48,7 @@
     license="COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0",
     packages=find_packages(),
     provides=[PKG],
-    install_requires=['lxml', 'requests'],
+    install_requires=['lxml', 'requests'], #requirements_file_to_list(),
     test_suite='tests',
     long_description=long_desc,
     classifiers=[

setup.py

@@ -37,7 +37,7 @@ def getTestSuite():
     suite.addTest(doctest.DocTestSuite(ebaysdk.config))
     suite.addTest(doctest.DocTestSuite(ebaysdk.response))
     suite.addTest(doctest.DocTestSuite(ebaysdk.connection))
-    suite.addTest(doctest.DocTestSuite(ebaysdk.http))
+    #suite.addTest(doctest.DocTestSuite(ebaysdk.http))
     suite.addTest(doctest.DocTestSuite(ebaysdk.shopping))
     suite.addTest(doctest.DocTestSuite(ebaysdk.trading))
     suite.addTest(doctest.DocTestSuite(ebaysdk.merchandising))