pep8 fixes and added tests

Author: timotheus

.gitignore

@@ -13,3 +13,4 @@ ebaysdk.egg-info/
 \.tox
 venv/
 venv*
+\.virtualenvs

ebaysdk/parallel.py

@@ -6,12 +6,12 @@
 Licensed under CDDL 1.0
 '''
 import sys
+from ebaysdk.exception import ConnectionError
+import grequests
+
 if sys.version_info[0] >= 3:
     raise ImportError('grequests does not work with python3+')
 
-import grequests
-from ebaysdk.exception import ConnectionError
-
 
 class Parallel(object):
     """

ebaysdk/soa/__init__.py

@@ -55,24 +55,6 @@ def load_from_app_config(self, app_config):
     def response_dict(self):
         return self.response.dict()
 
-        '''
-        if self._response_dict:
-            return self._response_dict
-
-        if self._response_content:
-
-            mydict = self.response.dict()
-            
-            try:
-                verb = self.verb + 'Response'
-                self._response_dict = mydict['Envelope']['Body'][verb]
-
-            except KeyError:
-                self._response_dict = mydict.get(self.verb + 'Response', mydict)
-
-        return self._response_dict
-        '''
-
     def build_request_headers(self, verb):
         return {
             'Content-Type': self.config.get('content_type'),

ebaysdk/trading/__init__.py

@@ -785,7 +785,7 @@ def _get_resp_body_errors(self):
                 .format(eClass=eClass, severity=eSeverity, code=eCode, shortMsg=eShortMsg,
                         longMsg=eLongMsg)
 
-            #from IPython import embed; embed()
+            # from IPython import embed; embed()
 
             if eSeverity == 'Warning':
                 warnings.append(msg)

samples/trading.py

@@ -189,6 +189,25 @@ def verifyAddItemErrorCodes(opts):
             }
         }
 
+        motors_item = {
+            'Item': {
+                'Category': '101',
+                'Title': 'My Title',
+                'ItemCompatibilityList': {
+                    'Compatibility': [
+                        {
+                            'CompatibilityNotes': 'Fits for all trims and engines.',
+                            'NameValueList': [
+                                {'Name': 'Year', 'Value': '2001'},
+                                {'Name': 'Make', 'Value': 'Honda'},
+                                {'Name': 'Model', 'Value': 'Accord'}
+                            ]
+                         },
+                    ]
+                }
+            }
+        }
+
         api.execute('VerifyAddItem', myitem)
 
     except ConnectionError as e:

tests/test_base.py

@@ -30,7 +30,7 @@
 except ImportError:
     pass
 
-os.environ.setdefault("EBAY_YAML", "ebay.yaml")
+# os.environ.setdefault("EBAY_YAML", "ebay.yaml")
 
 
 class TestBase(unittest.TestCase):
@@ -54,7 +54,13 @@ def test_run_doctest_connection(self):
         self.doctest(ebaysdk.connection)
 
     def test_run_doctest_shopping(self):
-        self.doctest(ebaysdk.shopping)
+        s = ebaysdk.shopping.Connection(config_file=os.environ.get('EBAY_YAML'))
+        resp = s.execute('GetCategoryInfo',
+            {'CategoryID': '-1',
+             'IncludeSelector': ['ChildCategories']})
+        self.assertEqual(s.response.reply.Ack, 'Success')
+        self.assertEqual(s.error(), None)
+        #self.doctest(ebaysdk.shopping)
 
     def test_run_doctest_trading(self):
         self.doctest(ebaysdk.trading)

tests/test_errors.py

@@ -17,7 +17,7 @@
 class TestErrors(unittest.TestCase):
 
     def test_single_item(self):
-        connection = ebaysdk.shopping.Connection(debug=True, version='799')
+        connection = ebaysdk.shopping.Connection(version='799', config_file=os.environ.get('EBAY_YAML'))
 
         for i in range(20):
             connection.execute('GetSingleItem', {

tests/test_request.py

@@ -0,0 +1,67 @@
+# -*- coding: utf-8 -*-
+
+'''
+© 2012-2013 eBay Software Foundation
+Authored by: Tim Keefer
+Licensed under CDDL 1.0
+'''
+
+from __future__ import absolute_import
+import os
+import unittest
+import re
+from ebaysdk.utils import dict2xml
+
+os.environ.setdefault("EBAY_YAML", "ebay.yaml")
+
+
+class TestBase(unittest.TestCase):
+
+    def test_motors_compat_request_xml(self):
+        motors_dict = {
+            'Item': {
+                'Category': '101',
+                'Title': 'My Title',
+                'ItemCompatibilityList': {
+                    'Compatibility': [
+                        {
+                            'CompatibilityNotes': 'Fits for all trims and engines.',
+                            'NameValueList': [
+                                {'Name': 'Year', 'Value': '2001'},
+                                {'Name': 'Make', 'Value': 'Honda'},
+                                {'Name': 'Model', 'Value': 'Accord'}
+                            ]
+                        },
+                    ]
+                }
+            }
+        }
+
+        motors_xml = """<Item>
+    <Category>101</Category>
+    <ItemCompatibilityList>
+        <Compatibility>
+            <CompatibilityNotes>Fits for all trims and engines.</CompatibilityNotes>
+            <NameValueList>
+                <Name>Year</Name><Value>2001</Value>
+            </NameValueList>
+            <NameValueList>
+                <Name>Make</Name><Value>Honda</Value>
+            </NameValueList>
+            <NameValueList>
+                <Name>Model</Name><Value>Accord</Value>
+            </NameValueList>
+        </Compatibility>
+    </ItemCompatibilityList>
+    <Title>My Title</Title>
+</Item> 
+        """
+
+        motors_xml = re.sub(r'>\s+<', '><', motors_xml)
+        motors_xml = re.sub(r'\s+$', '', motors_xml)
+
+        self.assertEqual(dict2xml(motors_dict), motors_xml)
+
+
+if __name__ == '__main__':
+    unittest.main()

tox.ini

@@ -2,8 +2,12 @@
 envlist = py27,py36
 
 [testenv]
+setenv =
+    EBAY_YAML = ebay_private.yaml
+
 commands = pep8 --ignore=E202,E501 ebaysdk 
-           pylint -E ebaysdk 
+           pylint -E ebaysdk
+           python setup.py test
 whitelist_externals = make
 deps = pep8
        pylint