2640 bug lo prostar not processing correctly (IMAP-Science-Operations-Center#2642)

* Fix testing for incorrect descriptor l1b star

* Hacky fix for L1A coordinate issue

Author: tmplummer

imap_processing/lo/l1b/lo_l1b.py

@@ -213,27 +213,30 @@ def lo_l1b(
             datasets_to_return.append(badtimes_ds)
 
     # if the dependencies are used to create Annotated Direct Events
-    if descriptor == "de":
+    elif descriptor == "de":
         logger.info("\nProcessing IMAP-Lo L1B Direct Events...")
         ds = l1b_de(sci_dependencies, anc_dependencies, attr_mgr_l1b, attr_mgr_l1a)
         datasets_to_return.append(ds)
 
     # If dependencies are used to create Histogram Rates
-    if descriptor == "all-rates":
+    elif descriptor == "all-rates":
         logger.info("\nProcessing IMAP-Lo L1B Hist and Monitor Rates...")
         ds = l1b_allrates(sci_dependencies, anc_dependencies, attr_mgr_l1b)
         datasets_to_return.extend(ds)
 
-    if descriptor == "derates":
+    elif descriptor == "derates":
         logger.info("\nProcessing IMAP-Lo L1B DE Rates...")
         ds = calculate_de_rates(sci_dependencies, anc_dependencies, attr_mgr_l1b)
         datasets_to_return.append(ds)
 
-    if descriptor == "star":
+    elif descriptor == "prostar":
         logger.info("\nProcessing IMAP-Lo L1B Star Sensor Profile...")
         ds = l1b_star(sci_dependencies, attr_mgr_l1b)
         datasets_to_return.append(ds)
 
+    else:
+        logger.warning(f"Unexpected descriptor: {descriptor!r}")
+
     return datasets_to_return
 
 
@@ -2354,6 +2357,14 @@ def l1b_star(
     l1b_nhk = sci_dependencies["imap_lo_l1b_nhk"]
     spin_data = sci_dependencies["imap_lo_l1a_spin"]
 
+    # L1A files have a coordinate of shcoarse due to DEPEND_0 issue.
+    # This is a temporary fix for that.
+    # TODO: Fix L1A shcoarse DEPEND_0 and then remove this
+    if "shcoarse" in l1a_star.dims:
+        var_shcoarse = xr.DataArray(l1a_star["shcoarse"].values, dims=("epoch",))
+        l1a_star = l1a_star.drop_vars("shcoarse")
+        l1a_star["shcoarse"] = var_shcoarse
+
     # Get sampling cadence from NHK
     sampling_cadence = get_sampling_cadence_from_nhk(l1b_nhk)
 

imap_processing/tests/lo/test_lo_l1b.py

@@ -927,6 +927,13 @@ def test_l1b_badtimes_skipped_if_empty():
     assert len(datasets) == 0
 
 
+def test_lo_l1b_unexpected_descriptor(caplog):
+    """Test that an unexpected descriptor logs a warning and returns empty list."""
+    datasets = lo_l1b({}, [], descriptor="unknown")
+    assert len(datasets) == 0
+    assert "Unexpected descriptor: 'unknown'" in caplog.text
+
+
 def test_resweep_histogram_success(l1b_histrates, anc_dependencies):
     # Arrange
     epoch_date = et_to_ttj2000ns(