update

Author: tobiste

R/ortensor.R

@@ -90,8 +90,9 @@ ortensor.default <- function(x, norm = TRUE, w = NULL, shift = NULL) {
   } else {
     n <- 1
   }
+  xw <- w * x
 
-  or <- (1 / n) * (t(x) %*% x)
+  or <- (1 / n) * (t(xw) %*% xw)
   # or <- matrix(nrow = 3, ncol = 3)
   # or[1, 1] <- sum(x[, 1]^2)
   # or[1, 2] <- sum(x[, 1] * x[, 2])

R/vector_stats.R

@@ -301,13 +301,12 @@ delta <- function(x, w = NULL, na.rm = TRUE) {
 }
 
 #' @rdname stats
+#' @param p integer. Number of parameters in the data space (2 for circle, 3 for a sphere)
 #' @export
-estimate_k <- function(x, w = NULL, na.rm = FALSE) {
+estimate_k <- function(x, w = NULL, na.rm = FALSE, p = 3) {
   Rbar <- vresultant(Vec3(x), w = w, mean = TRUE, na.rm = na.rm) |>
     vlength()
 
-  p <- 3
-
   (Rbar * (p - Rbar^2)) / (1 - Rbar^2)
 }