Skip to content

Commit 156c9c2

Browse files
authored
Merge pull request #565 from toggle-corp/feature-use-better-sorting
Use compareStringSearch instead of rate function
2 parents fd116fe + f9736ad commit 156c9c2

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

components/Input/MultiSelectInput/index.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ import memoize from 'memoize-one';
44
import {
55
listToMap,
66
caseInsensitiveSubmatch,
7-
getRatingForContentInString as rate,
8-
isDefined,
7+
compareStringSearch,
98
_cs,
109
} from '@togglecorp/fujs';
1110
import { FaramInputElement } from '@togglecorp/faram';
@@ -138,8 +137,10 @@ export class NormalMultiSelectInput extends React.PureComponent {
138137
value === undefined || caseInsensitiveSubmatch(labelSelector(option), value)
139138
),
140139
)
141-
.sort((a, b) => (
142-
rate(value, labelSelector(a)) - rate(value, labelSelector(b))
140+
.sort((a, b) => compareStringSearch(
141+
labelSelector(a),
142+
labelSelector(b),
143+
value,
143144
));
144145
return newOptions;
145146
})

components/Input/SelectInput/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
33
import memoize from 'memoize-one';
44
import {
55
caseInsensitiveSubmatch,
6-
getRatingForContentInString as rate,
6+
compareStringSearch,
77
_cs,
88
} from '@togglecorp/fujs';
99
import { FaramInputElement } from '@togglecorp/faram';
@@ -125,8 +125,10 @@ class SelectInput extends React.PureComponent {
125125
value === undefined || caseInsensitiveSubmatch(labelSelector(option), value)
126126
),
127127
)
128-
.sort((a, b) => (
129-
rate(value, labelSelector(a)) - rate(value, labelSelector(b))
128+
.sort((a, b) => compareStringSearch(
129+
labelSelector(a),
130+
labelSelector(b),
131+
value,
130132
));
131133
return newOptions;
132134
});

0 commit comments

Comments
 (0)