Skip to content

Commit 5694b2d

Browse files
author
Tomas Lycken
authored
Update nugets (#30)
* Remove System.ValueTuple This should be picked up from the .NET Standard Library instead. * Update xUnit and Moq Due to improved support for parallel test runs in xUnit 2.3, we need to explicitly disable parallel test runs of the EF tests, because they're all re-using the same db instance. A better solution would be to refactor the test fixture and base class to create a new db-connection instance for each test, and use that. * Use xUnit asserts more idiomatically
1 parent 059a106 commit 5694b2d

5 files changed

Lines changed: 7 additions & 9 deletions

File tree

src/RdbmsEventStore.EntityFramework.Tests/ExtensibilityTests/NonDefaultImplementationsTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using System.ComponentModel.DataAnnotations;
33
using System.ComponentModel.DataAnnotations.Schema;
44
using System.Data.Entity;
5-
using System.Linq;
65
using System.Text;
76
using System.Threading.Tasks;
87
using RdbmsEventStore.EntityFramework.Tests.Infrastructure;
@@ -84,7 +83,7 @@ public async Task CanReadEventsFromStoreWithNonDefaultImplementations()
8483

8584
var events = await store.Events(1);
8685

87-
Assert.Equal(1, events.Count());
86+
Assert.Single(events);
8887
}
8988
public void Dispose()
9089
{

src/RdbmsEventStore.EntityFramework.Tests/Infrastructure/AssemblyInitializerFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ public AssemblyInitializerFixture()
1010
}
1111
}
1212

13-
[CollectionDefinition(nameof(InMemoryDatabaseCollection))]
13+
[CollectionDefinition(nameof(InMemoryDatabaseCollection), DisableParallelization = true)]
1414
public class InMemoryDatabaseCollection : ICollectionFixture<AssemblyInitializerFixture> { }
1515
}

src/RdbmsEventStore.EntityFramework.Tests/RdbmsEventStore.EntityFramework.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
<ItemGroup>
1111
<PackageReference Include="Effort.EF6" Version="1.3.0" />
1212
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
13-
<PackageReference Include="xunit" Version="2.2.0" />
14-
<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
13+
<PackageReference Include="xunit" Version="2.3.0" />
14+
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.0" />
1515
</ItemGroup>
1616

1717
<ItemGroup>

src/RdbmsEventStore.Tests/RdbmsEventStore.Tests.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88

99
<ItemGroup>
1010
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
11-
<PackageReference Include="Moq" Version="4.7.137" />
12-
<PackageReference Include="xunit" Version="2.2.0" />
13-
<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
11+
<PackageReference Include="Moq" Version="4.7.142" />
12+
<PackageReference Include="xunit" Version="2.3.0" />
13+
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.0" />
1414
</ItemGroup>
1515

1616
<ItemGroup>

src/RdbmsEventStore/RdbmsEventStore.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
<ItemGroup>
2121
<PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
2222
<PackageReference Include="Nito.AsyncEx.Coordination" Version="1.0.2" />
23-
<PackageReference Include="System.ValueTuple" Version="4.4.0" />
2423
</ItemGroup>
2524

2625
</Project>

0 commit comments

Comments
 (0)