added: my solutions in javascript to the caesar cipher challenge#76
Open
ederalab wants to merge 2 commits into
Open
added: my solutions in javascript to the caesar cipher challenge#76ederalab wants to merge 2 commits into
ederalab wants to merge 2 commits into
Conversation
micheleriva
reviewed
Nov 1, 2021
| const letters = 26; | ||
|
|
||
| function encode(str, shift) { | ||
| shift = shift % letters |
Collaborator
There was a problem hiding this comment.
Please create a new constant value instead of re-assigning the function parameter 🙂
| if ((character >= "a" && character <= "z") || (character >= "A" && character <= "Z")) { | ||
| // if is lowercase | ||
| if (character >= "a" && character <= "z") { | ||
| ascii = 97 |
Collaborator
There was a problem hiding this comment.
Where does this ascii variable come from?
| ascii = 65 | ||
| } | ||
|
|
||
| new_str = letters + character.charCodeAt(0) - ascii |
Collaborator
There was a problem hiding this comment.
Please instantiate a new variable by using let or const keywords
| } | ||
|
|
||
|
|
||
| function decode(str, shift) { |
Collaborator
There was a problem hiding this comment.
Here you're repeating most of the encode function. Is there a way to avoid all those repetitions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.